linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org,
	Jia Hongtao <hongtao.jia@freescale.com>,
	B07421@freescale.com
Subject: Re: [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
Date: Thu, 25 Apr 2013 11:58:16 -0500	[thread overview]
Message-ID: <1366909096.30341.3@snotra> (raw)
In-Reply-To: <CA5B8197-1A55-4E6E-AE0C-CD015D97EC83@kernel.crashing.org> (from segher@kernel.crashing.org on Thu Apr 25 10:31:51 2013)

On 04/25/2013 10:31:51 AM, Segher Boessenkool wrote:
>> * Remove A variant of load instruction emulation
>=20
> Why is this?  You handle all other simple load insns, there is
> nothing special about LHA.  (I reviewed the V4 email thread, no
> reason for the chance is given there).

The LHA implementation in V5 was incorrect (didn't sign-extend).

-Scott=

  reply	other threads:[~2013-04-25 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  2:39 [PATCH 1/2] powerpc: Move opcode definitions from kvm/emulate.c to asm/ppc-opcode.h Jia Hongtao
2013-04-23  2:39 ` [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx Jia Hongtao
2013-04-25 15:31   ` Segher Boessenkool
2013-04-25 16:58     ` Scott Wood [this message]
2013-04-25 17:32       ` Segher Boessenkool
2013-04-27  2:26       ` Jia Hongtao-B38951
2013-04-27 13:31         ` Segher Boessenkool
2013-04-28  2:20           ` Jia Hongtao-B38951
2013-04-29 20:29         ` Scott Wood
2013-05-02  7:00           ` Jia Hongtao-B38951
2013-04-23  5:29 ` [PATCH 1/2] powerpc: Move opcode definitions from kvm/emulate.c to asm/ppc-opcode.h Michael Ellerman
2013-04-23  6:36   ` Jia Hongtao-B38951
2013-04-24  4:19     ` Benjamin Herrenschmidt
2013-04-26  2:40       ` Jia Hongtao-B38951

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366909096.30341.3@snotra \
    --to=scottwood@freescale.com \
    --cc=B07421@freescale.com \
    --cc=hongtao.jia@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).