From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "tiejun.chen" <tiejun.chen@windriver.com>
Cc: Scott Wood <scottwood@freescale.com>,
Mihai Caraman <mihai.caraman@freescale.com>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: Make hard_irq_disable() do the right thing vs. irq tracing
Date: Tue, 07 May 2013 17:25:20 +1000 [thread overview]
Message-ID: <1367911520.5769.12.camel@pasglop> (raw)
In-Reply-To: <5188AA2D.1040802@windriver.com>
On Tue, 2013-05-07 at 15:15 +0800, tiejun.chen wrote:
> Could we simplify this as follows:
>
> +#define hard_irq_disable() do { \
> + __hard_irq_disable(); \
> + if (get_paca()->soft_enabled) { \
> + trace_hardirqs_off(); \
> + get_paca()->soft_enabled = 0; \
> + } \
> + get_paca()->irq_happened |= PACA_IRQ_HARD_DIS; \
> +} while(0)
I'd rather not. When lockdep is not enabled trace_hardirqs_off() is a
nop and thus we have no conditional at all which is arguably better...
Cheers,
Ben.
prev parent reply other threads:[~2013-05-07 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 7:04 [PATCH] powerpc: Make hard_irq_disable() do the right thing vs. irq tracing Benjamin Herrenschmidt
2013-05-07 7:15 ` tiejun.chen
2013-05-07 7:25 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367911520.5769.12.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mihai.caraman@freescale.com \
--cc=scottwood@freescale.com \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).