From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH 17/22] powerpc/eeh: I/O chip PE log and bridge setup
Date: Wed, 15 May 2013 11:34:53 +0800 [thread overview]
Message-ID: <1368588898-16224-18-git-send-email-shangw@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368588898-16224-1-git-send-email-shangw@linux.vnet.ibm.com>
The patch adds backends to retrieve error log and configure p2p
bridges for the indicated PE.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
arch/powerpc/platforms/powernv/eeh-ioda.c | 57 ++++++++++++++++++++++++++++-
1 files changed, 55 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
index be2c336..2c78af4 100644
--- a/arch/powerpc/platforms/powernv/eeh-ioda.c
+++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
@@ -456,11 +456,64 @@ static int ioda_eeh_reset(struct eeh_pe *pe, int option)
return ret;
}
+/**
+ * ioda_eeh_get_log - Retrieve error log
+ * @pe: EEH PE
+ * @severity: Severity level of the log
+ * @drv_log: buffer to store the log
+ * @len: space of the log buffer
+ *
+ * The function is used to retrieve error log from P7IOC.
+ */
+static int ioda_eeh_get_log(struct eeh_pe *pe, int severity,
+ char *drv_log, unsigned long len)
+{
+ s64 ret;
+ unsigned long flags;
+ struct pci_controller *hose = pe->phb;
+ struct pnv_phb *phb = hose->private_data;
+
+ spin_lock_irqsave(&phb->lock, flags);
+
+ ret = opal_pci_get_phb_diag_data(phb->opal_id,
+ phb->diag.blob, PNV_PCI_DIAG_BUF_SIZE);
+ if (ret) {
+ spin_unlock_irqrestore(&phb->lock, flags);
+ pr_warning("%s: Failed to retrieve log for PHB#%x-PE#%x\n",
+ __func__, hose->global_number, pe->addr);
+ return -EIO;
+ }
+
+ /*
+ * FIXME: We probably need log the error in somewhere.
+ * Lets make it up in future.
+ */
+ /* pr_info("%s", phb->diag.blob); */
+
+ spin_unlock_irqrestore(&phb->lock, flags);
+
+ return 0;
+}
+
+/**
+ * ioda_eeh_configure_bridge - Configure the PCI bridges for the indicated PE
+ * @pe: EEH PE
+ *
+ * For particular PE, it might have included PCI bridges. In order
+ * to make the PE work properly, those PCI bridges should be configured
+ * correctly. However, we need do nothing on P7IOC since the reset
+ * function will do everything that should be covered by the function.
+ */
+static int ioda_eeh_configure_bridge(struct eeh_pe *pe)
+{
+ return 0;
+}
+
struct pnv_eeh_ops ioda_eeh_ops = {
.post_init = ioda_eeh_post_init,
.set_option = ioda_eeh_set_option,
.get_state = ioda_eeh_get_state,
.reset = ioda_eeh_reset,
- .get_log = NULL,
- .configure_bridge = NULL
+ .get_log = ioda_eeh_get_log,
+ .configure_bridge = ioda_eeh_configure_bridge
};
--
1.7.5.4
next prev parent reply other threads:[~2013-05-15 3:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 3:34 [PATCH v1 00/22] powerpc/eeh: Enhance converting EEH dev Gavin Shan
2013-05-15 3:34 ` [PATCH 01/22] " Gavin Shan
2013-05-15 3:34 ` [PATCH 02/22] powerpc/eeh: Function to tranverse PCI devices Gavin Shan
2013-05-15 3:34 ` [PATCH 03/22] powerpc/eeh: Make eeh_phb_pe_get() public Gavin Shan
2013-05-15 3:34 ` [PATCH 04/22] powerpc/eeh: Make eeh_pe_get() public Gavin Shan
2013-05-15 3:34 ` [PATCH 05/22] powerpc/eeh: Trace PCI bus from PE Gavin Shan
2013-05-15 3:34 ` [PATCH 06/22] powerpc/eeh: Make eeh_init() public Gavin Shan
2013-05-15 3:34 ` [PATCH 07/22] powerpc/eeh: EEH post initialization operation Gavin Shan
2013-05-15 3:34 ` [PATCH 08/22] powerpc/eeh: Refactor eeh_reset_pe_once() Gavin Shan
2013-05-15 3:34 ` [PATCH 09/22] powerpc/eeh: Delay EEH probe during hotplug Gavin Shan
2013-05-15 3:34 ` [PATCH 10/22] powerpc/eeh: Differentiate EEH events Gavin Shan
2013-05-15 3:34 ` [PATCH 11/22] powerpc/eeh: Sync OPAL API with firmware Gavin Shan
2013-05-15 3:34 ` [PATCH 12/22] powerpc/eeh: EEH backend for P7IOC Gavin Shan
2013-05-15 3:34 ` [PATCH 13/22] powerpc/eeh: I/O chip post initialization Gavin Shan
2013-05-15 3:34 ` [PATCH 14/22] powerpc/eeh: I/O chip EEH enable option Gavin Shan
2013-05-15 3:34 ` [PATCH 15/22] powerpc/eeh: I/O chip EEH state retrieval Gavin Shan
2013-05-15 3:34 ` [PATCH 16/22] powerpc/eeh: I/O chip PE reset Gavin Shan
2013-05-15 3:34 ` Gavin Shan [this message]
2013-05-15 3:34 ` [PATCH 18/22] powerpc/eeh: PowerNV EEH backends Gavin Shan
2013-05-15 3:34 ` [PATCH 19/22] powerpc/eeh: Initialization for PowerNV Gavin Shan
2013-05-15 3:34 ` [PATCH 20/22] powerpc/eeh: Enable EEH check for config access Gavin Shan
2013-05-15 3:34 ` [PATCH 21/22] powerpc/eeh: Process interrupts caused by EEH Gavin Shan
2013-05-15 3:34 ` [PATCH 22/22] powerpc/eeh: Connect EEH error interrupt handle Gavin Shan
2013-05-15 3:57 ` [PATCH v1 00/22] powerpc/eeh: Enhance converting EEH dev Benjamin Herrenschmidt
2013-05-15 5:30 ` Gavin Shan
2013-05-15 5:58 ` Benjamin Herrenschmidt
2013-05-15 8:47 ` Gavin Shan
2013-05-15 9:48 ` Benjamin Herrenschmidt
2013-05-16 2:44 ` Gavin Shan
-- strict thread matches above, loose matches on Subject: below --
2013-03-01 14:16 [PATCH v1 0/22] EEH support for PowerNV platform Gavin Shan
2013-03-01 14:17 ` [PATCH 17/22] powerpc/eeh: I/O chip PE log and bridge setup Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368588898-16224-18-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).