From: Kevin Hao <haokexin@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH 2/3] powerpc/fsl-pci: fix the unreachable warning message
Date: Tue, 21 May 2013 20:04:59 +0800 [thread overview]
Message-ID: <1369137900-5748-3-git-send-email-haokexin@gmail.com> (raw)
In-Reply-To: <1369137900-5748-1-git-send-email-haokexin@gmail.com>
The (1ull << mem_log) is never greater than mem unless mem_log++;
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
arch/powerpc/sysdev/fsl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 028ac1f..3833c8f 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -305,10 +305,10 @@ static void setup_pci_atmu(struct pci_controller *hose)
if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
/* Size window to exact size if power-of-two or one size up */
if ((1ull << mem_log) != mem) {
+ mem_log++;
if ((1ull << mem_log) > mem)
pr_info("%s: Setting PCI inbound window "
"greater than memory size\n", name);
- mem_log++;
}
piwar |= ((mem_log - 1) & PIWAR_SZ_MASK);
--
1.8.1.4
next prev parent reply other threads:[~2013-05-21 12:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 12:04 [PATCH 0/3] several cleanup patches for fsl pci Kevin Hao
2013-05-21 12:04 ` [PATCH 1/3] powerpc/mpc85xx: remove the unneeded pci init functions for corenet ds board Kevin Hao
2013-05-28 22:52 ` Scott Wood
2013-05-30 10:20 ` Kevin Hao
2013-05-30 18:54 ` Scott Wood
2013-05-31 6:41 ` Kevin Hao
2013-05-31 10:11 ` Benjamin Herrenschmidt
2013-06-01 10:59 ` Kevin Hao
2013-06-01 11:47 ` Benjamin Herrenschmidt
2013-06-02 0:07 ` Kevin Hao
2013-06-03 16:42 ` Scott Wood
2013-06-07 2:00 ` Kevin Hao
2013-06-08 0:00 ` Scott Wood
2013-07-23 22:31 ` Scott Wood
2013-07-25 12:54 ` Kevin Hao
2013-07-26 22:43 ` Scott Wood
2013-07-28 0:32 ` Kevin Hao
2013-05-31 6:43 ` Kevin Hao
2013-05-31 23:27 ` Scott Wood
2013-06-01 11:13 ` Kevin Hao
2013-05-21 12:04 ` Kevin Hao [this message]
2013-05-21 12:05 ` [PATCH 3/3] powerpc/fsl-pci: enable SWIOTLB in function setup_pci_atmu Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369137900-5748-3-git-send-email-haokexin@gmail.com \
--to=haokexin@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).