From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, dwg@au1.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH -V9 05/20] mm/THP: Don't use HPAGE_SHIFT in transparent hugepage code
Date: Wed, 22 May 2013 22:27:37 +0530 [thread overview]
Message-ID: <1369241872-15700-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1369241872-15700-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
For architectures like powerpc that support multiple explicit hugepage
sizes, HPAGE_SHIFT indicate the default explicit hugepage shift. For
THP to work the hugepage size should be same as PMD_SIZE. So use
PMD_SHIFT directly. So move the define outside CONFIG_TRANSPARENT_HUGEPAGE
#ifdef because we want to use these defines in generic code with
if (pmd_trans_huge()) conditional.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
include/linux/huge_mm.h | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index 528454c..cc276d2 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -58,12 +58,11 @@ extern pmd_t *page_check_address_pmd(struct page *page,
#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT)
#define HPAGE_PMD_NR (1<<HPAGE_PMD_ORDER)
+#define HPAGE_PMD_SHIFT PMD_SHIFT
+#define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT)
+#define HPAGE_PMD_MASK (~(HPAGE_PMD_SIZE - 1))
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
-#define HPAGE_PMD_SHIFT HPAGE_SHIFT
-#define HPAGE_PMD_MASK HPAGE_MASK
-#define HPAGE_PMD_SIZE HPAGE_SIZE
-
extern bool is_vma_temporary_stack(struct vm_area_struct *vma);
#define transparent_hugepage_enabled(__vma) \
@@ -181,9 +180,6 @@ extern int do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vm
unsigned long addr, pmd_t pmd, pmd_t *pmdp);
#else /* CONFIG_TRANSPARENT_HUGEPAGE */
-#define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; })
-#define HPAGE_PMD_MASK ({ BUILD_BUG(); 0; })
-#define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; })
#define hpage_nr_pages(x) 1
--
1.8.1.2
next prev parent reply other threads:[~2013-05-22 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 16:57 [PATCH -V9 00/20] THP support for PPC64 Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 01/20] mm/THP: Use pmd_populate to update the pmd with pgtable_t pointer Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 02/20] mm/THP: Use the right function when updating access flags Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 03/20] mm/THP: Add pmd args to pgtable deposit and withdraw APIs Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 04/20] mm/THP: withdraw the pgtable after pmdp related operations Aneesh Kumar K.V
2013-05-22 16:57 ` Aneesh Kumar K.V [this message]
2013-05-22 16:57 ` [PATCH -V9 06/20] mm/THP: deposit the transpare huge pgtable before set_pmd Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 07/20] powerpc/THP: Double the PMD table size for THP Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 08/20] powerpc/THP: Implement transparent hugepages for ppc64 Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 09/20] powerpc: move find_linux_pte_or_hugepte and gup_hugepte to common code Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 10/20] powerpc: Update find_linux_pte_or_hugepte to handle transparent hugepages Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 11/20] powerpc: Replace find_linux_pte with find_linux_pte_or_hugepte Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 12/20] powerpc: Update gup_pmd_range to handle transparent hugepages Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 13/20] powerpc/THP: Add code to handle HPTE faults for hugepages Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 14/20] powerpc: Make linux pagetable walk safe with THP enabled Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 15/20] powerpc: Prevent gcc to re-read the pagetables Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 16/20] powerpc/THP: Enable THP on PPC64 Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 17/20] powerpc: Optimize hugepage invalidate Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 18/20] powerpc: disable assert_pte_locked for collapse_huge_page Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 19/20] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index Aneesh Kumar K.V
2013-05-22 16:57 ` [PATCH -V9 20/20] powerpc: split hugepage when using subpage protection Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369241872-15700-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).