From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7D8A92C0174 for ; Tue, 28 May 2013 07:52:31 +1000 (EST) Message-ID: <1369691406.3557.35.camel@pasglop> Subject: Re: [PATCH 1/2] ARM: kirkwood: proper retain MAC address workaround on DT ethernet From: Benjamin Herrenschmidt To: Arnd Bergmann Date: Tue, 28 May 2013 07:50:06 +1000 In-Reply-To: <2255648.0KEmXfjCx5@wuerfel> References: <1369253042-15082-1-git-send-email-sebastian.hesselbarth@gmail.com> <51A33447.80305@gmail.com> <1369655404.3557.33.camel@pasglop> <2255648.0KEmXfjCx5@wuerfel> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: andrew@lunn.ch, jason@lakedaemon.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, grant.likely@linaro.org, linuxppc-dev@lists.ozlabs.org, David Miller , buytenh@wantstofly.org, Sebastian Hesselbarth List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2013-05-27 at 14:47 +0200, Arnd Bergmann wrote: > On Monday 27 May 2013 21:50:04 Benjamin Herrenschmidt wrote: > > However, that wouldn't help much with the allocation/leak problem, > > though at least it would be easier to use. It could also *try* to re-use > > the current allocation if the new content is of smaller or equal size. > > I thought that dtc tried to aggressively save space by folding identical > strings. If you tried to reuse a property that had its contents shared > with another one, you would get interesting results I guess. It used to be only property names, unless that has changed in recent dtc. But that's a good point, we probably want a flag in struct property like we have for nodes, indicating whether it comes from the original fdt data pool or not. Cheers, Ben.