From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] KVM: PPC: Book3S: Add support for H_IPOLL and H_XIRR_X in XICS emulation
Date: Thu, 30 May 2013 09:57:32 +1000 [thread overview]
Message-ID: <1369871852.3928.79.camel@pasglop> (raw)
In-Reply-To: <1369870703.18630.49@snotra>
On Wed, 2013-05-29 at 18:38 -0500, Scott Wood wrote:
> > Yes. I'd like to have them in. Their implementation is actually fairly
> > trivial and they cannot be emulated by qemu if the rest of the XICS is
> > in the kernel, so it's a problem.
>
> OK. Does it make more sense for you to take it as Paul suggested, or
> for Gleb or Marcelo to pick it up directly?
I'll take it.
> Then rm_action should always be 0 for these hcalls, right? So there's
> no correctness reason to keep the hcalls in separate switch
> statements. You shave off a few cycles checking rm_action, at the cost
> of needing to change kvmppc_xics_hcall() if a real-mode version of
> these hcalls is ever done.
No, because rm_action will also be 0 if the hcall was fully done in real
mode (which can happen, that's our fast path), in which case we do *NOT*
want to to be re-done in virtual mode.
That's why we always return whether rm_action is 0 or not when real-mode
is enabled.
Cheers,
Ben.
next prev parent reply other threads:[~2013-05-29 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 1:42 [PATCH] KVM: PPC: Book3S: Add support for H_IPOLL and H_XIRR_X in XICS emulation Paul Mackerras
2013-05-28 17:41 ` Scott Wood
2013-05-29 0:41 ` Benjamin Herrenschmidt
2013-05-29 23:38 ` Scott Wood
2013-05-29 23:57 ` Benjamin Herrenschmidt [this message]
2013-05-30 0:07 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369871852.3928.79.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mtosatti@redhat.com \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).