* [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff
@ 2013-05-30 7:07 liguang
2013-05-30 7:14 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: liguang @ 2013-05-30 7:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel, liguang
orderly_poweroff is expecting a bool parameter, so
use 'ture' instead '1'
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
arch/powerpc/platforms/pseries/ras.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c4dfccd..79b9502 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -83,7 +83,7 @@ static void handle_system_shutdown(char event_modifier)
switch (event_modifier) {
case EPOW_SHUTDOWN_NORMAL:
pr_emerg("Firmware initiated power off");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;
case EPOW_SHUTDOWN_ON_UPS:
@@ -95,13 +95,13 @@ static void handle_system_shutdown(char event_modifier)
pr_emerg("Loss of system critical functions reported by "
"firmware");
pr_emerg("Check RTAS error log for details");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;
case EPOW_SHUTDOWN_AMBIENT_TEMPERATURE_TOO_HIGH:
pr_emerg("Ambient temperature too high reported by firmware");
pr_emerg("Check RTAS error log for details");
- orderly_poweroff(1);
+ orderly_poweroff(true);
break;
default:
@@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
case EPOW_SYSTEM_HALT:
pr_emerg("Firmware initiated power off");
- orderly_poweroff(1);
+ orderly_poweroff(ture);
break;
case EPOW_MAIN_ENCLOSURE:
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff
2013-05-30 7:07 [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff liguang
@ 2013-05-30 7:14 ` Joe Perches
2013-05-30 7:20 ` li guang
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2013-05-30 7:14 UTC (permalink / raw)
To: liguang; +Cc: Paul Mackerras, linuxppc-dev, linux-kernel
On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
> orderly_poweroff is expecting a bool parameter, so
> use 'ture' instead '1'
[]
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
[]
> @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
>
> case EPOW_SYSTEM_HALT:
> pr_emerg("Firmware initiated power off");
> - orderly_poweroff(1);
> + orderly_poweroff(ture);
> break;
Compile your patches _before_ submitting them please.
"true" not "ture" here and in the commit message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff
2013-05-30 7:14 ` Joe Perches
@ 2013-05-30 7:20 ` li guang
0 siblings, 0 replies; 3+ messages in thread
From: li guang @ 2013-05-30 7:20 UTC (permalink / raw)
To: Joe Perches; +Cc: Paul Mackerras, linuxppc-dev, linux-kernel
=E5=9C=A8 2013-05-30=E5=9B=9B=E7=9A=84 00:14 -0700=EF=BC=8CJoe Perches=E5=
=86=99=E9=81=93=EF=BC=9A
> On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
> > orderly_poweroff is expecting a bool parameter, so
> > use 'ture' instead '1'
> []
> > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platfo=
rms/pseries/ras.c
> []
> > @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *=
log)
> > =20
> > case EPOW_SYSTEM_HALT:
> > pr_emerg("Firmware initiated power off");
> > - orderly_poweroff(1);
> > + orderly_poweroff(ture);
> > break;
>=20
> Compile your patches _before_ submitting them please.
>=20
> "true" not "ture" here and in the commit message.
>=20
right, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 7:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 7:07 [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff liguang
2013-05-30 7:14 ` Joe Perches
2013-05-30 7:20 ` li guang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).