From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: wolfking <wolfking2000@msn.com>, linuxppc-dev@ozlabs.org
Subject: Re: can't access PCIe card under sbc8548
Date: Fri, 31 May 2013 20:00:04 +1000 [thread overview]
Message-ID: <1369994404.3928.131.camel@pasglop> (raw)
In-Reply-To: <1369931094.14679.6@snotra>
On Thu, 2013-05-30 at 11:24 -0500, Scott Wood wrote:
> ioremap() and out_bex/in_bex are not appropriate for PCI I/O regions
> (and presumably that's what it is, if pci_iomap is calling
> ioport_map). Big-endian is not appropriate for PCI in any case.
>
> The whole point of pci_iomap() appears to be that the driver doesn't
> need to care whether it's MMIO or PIO, and can use ioread/writeX on the
> resulting cookie. If PPC is messing this up it's not the driver's
> fault.
We are not messing this up and it should work.
Cheers,
Ben.
next prev parent reply other threads:[~2013-05-31 10:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 3:42 can't access PCIe card under sbc8548 wolfking
2013-05-30 5:56 ` tiejun.chen
2013-05-30 7:19 ` wolfking
2013-05-30 8:47 ` tiejun.chen
2013-05-30 9:15 ` wolfking
2013-05-30 9:30 ` tiejun.chen
2013-05-30 7:32 ` wolfking
2013-05-30 10:42 ` tiejun.chen
2013-05-30 12:49 ` wolfking
2013-05-30 16:24 ` Scott Wood
2013-05-31 1:34 ` tiejun.chen
2013-05-31 2:27 ` wolfking
2013-05-31 10:00 ` Benjamin Herrenschmidt [this message]
2013-05-30 10:02 ` wolfking
2013-05-30 10:08 ` tiejun.chen
2013-05-30 12:45 ` wolfking
2013-05-30 16:29 ` Scott Wood
2013-05-31 0:40 ` wolfking
2013-05-31 10:01 ` Benjamin Herrenschmidt
2013-05-31 12:46 ` wolfking
2013-06-08 7:00 ` wolfking
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369994404.3928.131.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=wolfking2000@msn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).