linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/3] powerpc/mpc85xx: remove the unneeded pci init functions for corenet ds board
Date: Sat, 01 Jun 2013 21:47:16 +1000	[thread overview]
Message-ID: <1370087236.3766.43.camel@pasglop> (raw)
In-Reply-To: <20130601105936.GA1850@pek-khao-d1.corp.ad.wrs.com>

On Sat, 2013-06-01 at 18:59 +0800, Kevin Hao wrote:

> The effect of this change is that the isa_io_base will be 0 and the IO
> resource are equal to the virtual address of the IO space. But the IO
> functions such as outx/inx should work as well. This is why I ask the
> above question. What do you think about this? Are there any subtle bugs
> that will be triggered by this?

I don't see any obvious reason why that wouldn't work but like anything
in that area, it needs a bit of testing & hammering to be sure ;-)

In fact it would work on pmac32 as well since those generally don't have
legacy crap either.

So I have no fundamental objection, it just needs testing. My worry is
that we need to make sure we don't break old chrp and I don't have any
to test with. I'm happy to drop support for stuff nobody uses anymore
(we did drop PReP after all and I'm *that* close to drop power3) but as
long as somebody is still using a CHRP RS6K or a Pegasos I can't quite
drop those... And they do have legacy ISA crap to deal with.

Cheers,
Ben.

  reply	other threads:[~2013-06-01 11:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 12:04 [PATCH 0/3] several cleanup patches for fsl pci Kevin Hao
2013-05-21 12:04 ` [PATCH 1/3] powerpc/mpc85xx: remove the unneeded pci init functions for corenet ds board Kevin Hao
2013-05-28 22:52   ` Scott Wood
2013-05-30 10:20     ` Kevin Hao
2013-05-30 18:54       ` Scott Wood
2013-05-31  6:41         ` Kevin Hao
2013-05-31 10:11           ` Benjamin Herrenschmidt
2013-06-01 10:59             ` Kevin Hao
2013-06-01 11:47               ` Benjamin Herrenschmidt [this message]
2013-06-02  0:07                 ` Kevin Hao
2013-06-03 16:42                   ` Scott Wood
2013-06-07  2:00                     ` Kevin Hao
2013-06-08  0:00                       ` Scott Wood
2013-07-23 22:31                       ` Scott Wood
2013-07-25 12:54                         ` Kevin Hao
2013-07-26 22:43                           ` Scott Wood
2013-07-28  0:32                             ` Kevin Hao
2013-05-31  6:43         ` Kevin Hao
2013-05-31 23:27           ` Scott Wood
2013-06-01 11:13             ` Kevin Hao
2013-05-21 12:04 ` [PATCH 2/3] powerpc/fsl-pci: fix the unreachable warning message Kevin Hao
2013-05-21 12:05 ` [PATCH 3/3] powerpc/fsl-pci: enable SWIOTLB in function setup_pci_atmu Kevin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370087236.3766.43.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=haokexin@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).