From: Michael Ellerman <michael@ellerman.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Michael Neuling <mikey@neuling.org>,
sukadev@linux.vnet.ibm.com, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH] powerpc/perf: Fix deadlock caused by calling printk() in PMU exception
Date: Tue, 04 Jun 2013 19:50:32 +1000 [thread overview]
Message-ID: <1370339432.15166.6.camel@concordia> (raw)
In-Reply-To: <51ADADEB.1040109@linux.vnet.ibm.com>
On Tue, 2013-06-04 at 14:35 +0530, Anshuman Khandual wrote:
> > + seq_printf(p, "%*s: ", prec, "PMS");
>
> Lets make this PMIS or PMI_S instead of PMS.
Everything else is aligned using a three character prefix, so that would
stuff the alignment up.
>
> > + for_each_online_cpu(j)
> > + seq_printf(p, "%10u ", per_cpu(irq_stat, j).pmu_irqs);
>
> This would be pmu_spurious_irqs instead of pmu_irqs.
Yep, thanks for reviewing.
I'm actually thinking I'll drop the counter, at least until we can be
sure it's not us causing the spurious interrupts.
cheers
next prev parent reply other threads:[~2013-06-04 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 4:20 [PATCH] powerpc/perf: Fix deadlock caused by calling printk() in PMU exception Michael Ellerman
2013-06-04 9:05 ` Anshuman Khandual
2013-06-04 9:50 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-06 3:58 Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370339432.15166.6.camel@concordia \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).