From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"anton@enomsg.org" <anton@enomsg.org>,
Wang Dongsheng-B40534 <B40534@freescale.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: add Book E support to 64-bit hibernation
Date: Tue, 18 Jun 2013 10:17:30 +1000 [thread overview]
Message-ID: <1371514650.21896.160.camel@pasglop> (raw)
In-Reply-To: <1371513683.9073.6@snotra>
On Mon, 2013-06-17 at 19:01 -0500, Scott Wood wrote:
> I really doubt the exception scratch registers need to be saved --
> we're not trying to restore into the middle of an exception
> prolog/epilog.
>
> book3s has the PACA as well and they don't save it. Don't we rely on
> things like boot-time memory allocations happening in the same place
> when we resume? extlb is part of the PACA, so the same applies.
I doubt we seriously tested hibernation :-) The PACA SPR should
definitely be saved/restored.
> Granted, this isn't performance critical so it may seem better to
> save/restore just in case, but there's value in not unnecessarily
> deviating from what book3s does.
Cheers,
Ben.
next prev parent reply other threads:[~2013-06-18 0:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 10:37 [PATCH 1/2] powerpc: add Book E support to 64-bit hibernation Wang Dongsheng
2013-06-09 10:37 ` [PATCH 2/2] powerpc/hibernate: add restore mmu context after resume Wang Dongsheng
2013-07-10 10:11 ` Wang Dongsheng-B40534
2013-07-10 21:42 ` Scott Wood
2013-07-12 4:04 ` Wang Dongsheng-B40534
2013-07-12 21:54 ` Scott Wood
2013-07-12 23:06 ` Benjamin Herrenschmidt
2013-08-07 9:55 ` Wang Dongsheng-B40534
2013-06-12 22:03 ` [PATCH 1/2] powerpc: add Book E support to 64-bit hibernation Scott Wood
2013-06-13 9:55 ` Wang Dongsheng-B40534
2013-06-13 16:51 ` Scott Wood
2013-06-17 5:54 ` Wang Dongsheng-B40534
2013-06-18 0:01 ` Scott Wood
2013-06-18 0:17 ` Benjamin Herrenschmidt [this message]
2013-06-18 0:22 ` Scott Wood
2013-06-18 1:29 ` Benjamin Herrenschmidt
2013-07-10 9:41 ` Wang Dongsheng-B40534
2013-07-10 9:51 ` Benjamin Herrenschmidt
2013-07-10 10:05 ` Wang Dongsheng-B40534
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371514650.21896.160.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B07421@freescale.com \
--cc=B40534@freescale.com \
--cc=anton@enomsg.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).