linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/THP: Wait for all hash_page calls to finish before invalidating HPTE entries
Date: Wed, 19 Jun 2013 20:18:33 +1000	[thread overview]
Message-ID: <1371637113.21896.274.camel@pasglop> (raw)
In-Reply-To: <9335.1371626096@ale.ozlabs.ibm.com>

On Wed, 2013-06-19 at 17:14 +1000, Michael Neuling wrote:

> > This is a bug fix. The details can be found at 
> 
> Can you make this more obvious in the changelog (as well as making it 80
> col).  I don't see 'bug' mentioned anywhere.  'Fix' is mentioned
> somewhere in the middle of the changelog.
> 
> > 
> > http://article.gmane.org/gmane.linux.ports.ppc.embedded/60266
> 
> OK, but V10 THP is not in yet, right?  So why not roll it into that
> series rather than pushing broken stuff and fixing it?

Right, this is expected. This fix is a result of me asking him to do it
that way on ST and should eventually be folded in the series (or
re-ordered to be in there before the patch that enables THP).

Cheers,
Ben.

      reply	other threads:[~2013-06-19 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  6:44 [PATCH] powerpc/THP: Wait for all hash_page calls to finish before invalidating HPTE entries Aneesh Kumar K.V
2013-06-19  6:55 ` Michael Neuling
2013-06-19  7:04   ` Aneesh Kumar K.V
2013-06-19  7:14     ` Michael Neuling
2013-06-19 10:18       ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371637113.21896.274.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).