From: Michael Ellerman <michael@ellerman.id.au>
To: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Cc: icycoder@gmail.com, linux-kernel@vger.kernel.org,
xiaoguangrong@linux.vnet.ibm.com, acme@redhat.com,
paulus@samba.org, sukadev@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name
Date: Thu, 20 Jun 2013 11:21:22 +1000 [thread overview]
Message-ID: <1371691282.21846.1.camel@concordia> (raw)
In-Reply-To: <1371633326-7696-1-git-send-email-runzhen@linux.vnet.ibm.com>
On Wed, 2013-06-19 at 17:15 +0800, Runzhen Wang wrote:
> In the Power7 PMU guide:
> https://www.power.org/documentation/commonly-used-metrics-for-performance-analysis/
> PM_BRU_MPRED is referred to as PM_BR_MPRED.
>
> This patch fix the typo by changing the name of the event in kernel and
> documentation accordingly.
>
> Signed-off-by: Runzhen Wang <runzhen@linux.vnet.ibm.com>
> ---
> .../testing/sysfs-bus-event_source-devices-events | 2 +-
> arch/powerpc/perf/power7-pmu.c | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> index 8b25ffb..3c1cc24 100644
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> @@ -29,7 +29,7 @@ Description: Generic performance monitoring events
>
> What: /sys/devices/cpu/events/PM_1PLUS_PPC_CMPL
> /sys/devices/cpu/events/PM_BRU_FIN
> - /sys/devices/cpu/events/PM_BRU_MPRED
> + /sys/devices/cpu/events/PM_BR_MPRED
So you're changing the ABI.
I think that's probably OK, but you at least need to mention _why_ you
think it's OK.
cheers
next prev parent reply other threads:[~2013-06-20 1:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 9:15 [PATCH 1/2] perf tools: fix a typo of a Power7 event name Runzhen Wang
2013-06-19 9:15 ` [PATCH 2/2] perf tools: Make Power7 events available for perf Runzhen Wang
2013-06-19 16:14 ` Sukadev Bhattiprolu
2013-06-20 1:41 ` Michael Ellerman
2013-06-20 10:57 ` David Laight
2013-06-19 16:13 ` [PATCH 1/2] perf tools: fix a typo of a Power7 event name Sukadev Bhattiprolu
2013-06-20 1:21 ` Michael Ellerman [this message]
2013-06-20 2:28 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371691282.21846.1.camel@concordia \
--to=michael@ellerman.id.au \
--cc=acme@redhat.com \
--cc=icycoder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).