From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/6] powerpc/eeh: Don't collect PCI-CFG data on PHB
Date: Tue, 25 Jun 2013 21:55:15 +1000 [thread overview]
Message-ID: <1372161315.3944.201.camel@pasglop> (raw)
In-Reply-To: <1372154461-29674-2-git-send-email-shangw@linux.vnet.ibm.com>
On Tue, 2013-06-25 at 18:00 +0800, Gavin Shan wrote:
> + /*
> + * When the PHB is fenced or dead, it's pointless to collect
> + * the data from PCI config space because it should return
> + * 0xFF's. For ER, we still retrieve the data from the PCI
> + * config space.
> + */
> + if (eeh_probe_mode_dev() &&
> + (pe->type & EEH_PE_PHB) &&
> + (pe->state & (EEH_PE_ISOLATED | EEH_PE_PHB_DEAD)))
> + valid_cfg_log = false;
> +
I'm still unsure about that one. EEH_PE_ISOLATED could be the result
of a normal ER of PE#0 (which can happen for various reasons other
than a fence) in which case the config space is available and
interesting.
I would either not bother and collect the FF's, or make this specific
to fence and only fence.
Cheers,
Ben.
next prev parent reply other threads:[~2013-06-25 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 10:00 [PATCH v2 00/6] Follow-up fixes for EEH on PowerNV Gavin Shan
2013-06-25 10:00 ` [PATCH 1/6] powerpc/eeh: Don't collect PCI-CFG data on PHB Gavin Shan
2013-06-25 11:55 ` Benjamin Herrenschmidt [this message]
2013-06-25 23:49 ` Gavin Shan
2013-06-25 23:57 ` Benjamin Herrenschmidt
2013-06-26 0:12 ` Gavin Shan
2013-06-25 11:56 ` Benjamin Herrenschmidt
2013-06-25 23:50 ` Gavin Shan
2013-06-25 10:00 ` [PATCH 2/6] powerpc/eeh: Check PCIe link after reset Gavin Shan
2013-06-25 11:58 ` Benjamin Herrenschmidt
2013-06-25 23:54 ` Gavin Shan
2013-06-25 10:00 ` [PATCH 3/6] powerpc/powernv: Replace variables with flags Gavin Shan
2013-06-25 10:00 ` [PATCH 4/6] powerpc/eeh: Fix address catch for PowerNV Gavin Shan
2013-06-25 10:01 ` [PATCH 5/6] powerpc/eeh: Refactor the output message Gavin Shan
2013-06-25 10:01 ` [PATCH 6/6] powerpc/eeh: Avoid build warnings Gavin Shan
-- strict thread matches above, loose matches on Subject: below --
2013-06-26 1:38 [PATCH v3 00/6] Follow-up fixes for EEH on PowerNV Gavin Shan
2013-06-26 1:38 ` [PATCH 1/6] powerpc/eeh: Don't collect PCI-CFG data on PHB Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372161315.3944.201.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).