linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/powernv: Mark pnv_pci_init_ioda2_phb() as __init
Date: Wed, 03 Jul 2013 08:01:18 +1000	[thread overview]
Message-ID: <1372802478.4122.24.camel@pasglop> (raw)
In-Reply-To: <20130702182003.28238.61942.stgit@bhelgaas-glaptop>

On Tue, 2013-07-02 at 12:20 -0600, Bjorn Helgaas wrote:
> Mark pnv_pci_init_ioda2_phb() as __init.  It is called only from an
> init function (pnv_pci_init()), and it calls an init function
> (pnv_pci_init_ioda_phb()):
> 
>     pnv_pci_init                # init
>       pnv_pci_init_ioda2_phb    # non-init
> 	pnv_pci_init_ioda_phb   # init
> 
> This should fix a section mismatch warning.

Thanks. I should look at those warnings more often...

Cheers,
Ben.

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 9c9d15e..dfbb03d 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1210,7 +1210,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np, int ioda_type)
>  		opal_pci_set_pe(phb_id, 0, 0, 7, 1, 1 , OPAL_MAP_PE);
>  }
>  
> -void pnv_pci_init_ioda2_phb(struct device_node *np)
> +void __init pnv_pci_init_ioda2_phb(struct device_node *np)
>  {
>  	pnv_pci_init_ioda_phb(np, PNV_PHB_IODA2);
>  }

      reply	other threads:[~2013-07-02 22:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 18:20 [PATCH] powerpc/powernv: Mark pnv_pci_init_ioda2_phb() as __init Bjorn Helgaas
2013-07-02 22:01 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372802478.4122.24.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).