From: Scott Wood <scottwood@freescale.com>
To: Tudor Laurentiu <Laurentiu.Tudor@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH][v2] powerpc/85xx: Move ePAPR paravirt initialization earlier
Date: Wed, 3 Jul 2013 09:52:46 -0500 [thread overview]
Message-ID: <1372863166.8183.129@snotra> (raw)
In-Reply-To: <51D41937.3000509@freescale.com> (from Laurentiu.Tudor@freescale.com on Wed Jul 3 07:29:43 2013)
On 07/03/2013 07:29:43 AM, Tudor Laurentiu wrote:
> On 07/02/2013 08:55 PM, Scott Wood wrote:
>> On 07/02/2013 07:46:29 AM, Laurentiu Tudor wrote:
>>> - insts =3D of_get_property(hyper_node, "hcall-instructions", &len);
>>> - if (!insts)
>>> - return -ENODEV;
>>> +#if !defined(CONFIG_64BIT) || defined(CONFIG_PPC_BOOK3E_64)
>>> + if (of_get_flat_dt_prop(node, "has-idle", NULL))
>>> + ppc_md.power_save =3D epapr_ev_idle;
>>> +#endif
>>=20
>> Why are you doing this before processing hcall-instructions?
>>=20
>=20
> Nothing of importance. The code seemed more clear to me.
It seems wrong to expose epapr_ev_idle to ppc_md before the hcall has =20
been patched in, even if you don't expect to actually go idle at this =20
point.
-Scott=
next prev parent reply other threads:[~2013-07-03 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 12:46 [PATCH][v2] powerpc/85xx: Move ePAPR paravirt initialization earlier Laurentiu Tudor
2013-07-02 17:55 ` Scott Wood
2013-07-03 12:29 ` Tudor Laurentiu
2013-07-03 14:52 ` Scott Wood [this message]
2013-07-03 15:13 ` Tudor Laurentiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372863166.8183.129@snotra \
--to=scottwood@freescale.com \
--cc=Laurentiu.Tudor@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).