From: Scott Wood <scottwood@freescale.com>
To: James Yang <James.Yang@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC][PATCH 1/2] powerpc/booke: extend PTRACE_SINGLEBLOCK for BookE Branch Taken Debug
Date: Tue, 9 Jul 2013 11:53:45 -0500 [thread overview]
Message-ID: <1373388825.8183.192@snotra> (raw)
In-Reply-To: <1373062265-4267-2-git-send-email-James.Yang@freescale.com> (from James.Yang@freescale.com on Fri Jul 5 17:11:04 2013)
On 07/05/2013 05:11:04 PM, James Yang wrote:
> This patch makes available the unmodified BookE branch taken debug
> exception through PTRACE_SINGLEBLOCK if the ptrace() addr parameter is
> set to 2.
This is hacky -- if we must retain the existing PTRACE_SINGLEBLOCK =20
semantics (which aren't actually documented anywhere AFAICT -- if the =20
details are meant to be implementation-defined, then don't we have some =20
freedom here to actually do what the hardware does, especially if we =20
can't find existing users?), then perhaps a new PTRACE_WHATEVER should =20
be defined.
At the very least, magic numbers should be given symbolic names.
-Scott=
next prev parent reply other threads:[~2013-07-09 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 22:11 [RFC][PATCH 0/2] powerpc/booke: PTRACE_SINGLEBLOCK support for BookE James Yang
2013-07-05 22:11 ` [RFC][PATCH 1/2] powerpc/booke: extend PTRACE_SINGLEBLOCK for BookE Branch Taken Debug James Yang
2013-07-09 16:53 ` Scott Wood [this message]
2013-07-05 22:11 ` [RFC][PATCH 2/2] powerpc/booke: revert PTRACE_SINGLEBLOCK to BookE behavior James Yang
2013-07-06 0:21 ` Benjamin Herrenschmidt
2013-07-06 5:01 ` James Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373388825.8183.192@snotra \
--to=scottwood@freescale.com \
--cc=James.Yang@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).