* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-05-30 17:47 ` [PATCH 00/12] dma: various minor clean ups for slave drivers Vinod Koul
@ 2013-05-30 18:32 ` Andy Shevchenko
2013-07-15 9:37 ` Vinod Koul
2013-06-01 0:09 ` Dan Williams
2013-07-10 7:54 ` Andy Shevchenko
2 siblings, 1 reply; 10+ messages in thread
From: Andy Shevchenko @ 2013-05-30 18:32 UTC (permalink / raw)
To: Vinod Koul
Cc: Shawn Guo, Stephen Warren, linux-kernel@vger.kernel.org,
Andy Shevchenko, Zhang Wei, Dan Williams, linux-tegra,
linuxppc-dev
On Thu, May 30, 2013 at 8:47 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote:
>> Here is a set of small independent patches that clean up or fix minor things
>> across DMA slave drivers.
> The series looks fine. I am going to wait a day more and apply, pls speak up if
> you disagree and ack if you agree
I'm not in hurry with it. Please, take your time and do whatever it requires.
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-05-30 18:32 ` Andy Shevchenko
@ 2013-07-15 9:37 ` Vinod Koul
2013-07-15 10:21 ` Andy Shevchenko
0 siblings, 1 reply; 10+ messages in thread
From: Vinod Koul @ 2013-07-15 9:37 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Shawn Guo, Stephen Warren, linux-kernel@vger.kernel.org,
Andy Shevchenko, Zhang Wei, Dan Williams, linux-tegra,
linuxppc-dev
On Thu, May 30, 2013 at 09:32:19PM +0300, Andy Shevchenko wrote:
> >> Here is a set of small independent patches that clean up or fix minor things
> >> across DMA slave drivers.
Applied thanks
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-07-15 9:37 ` Vinod Koul
@ 2013-07-15 10:21 ` Andy Shevchenko
2013-07-15 9:59 ` Vinod Koul
0 siblings, 1 reply; 10+ messages in thread
From: Andy Shevchenko @ 2013-07-15 10:21 UTC (permalink / raw)
To: Vinod Koul
Cc: Shawn Guo, Stephen Warren, linux-kernel@vger.kernel.org,
Andy Shevchenko, Andy Shevchenko, Zhang Wei, Dan Williams,
linux-tegra, linuxppc-dev
On Mon, 2013-07-15 at 15:07 +0530, Vinod Koul wrote:=20
> On Thu, May 30, 2013 at 09:32:19PM +0300, Andy Shevchenko wrote:
> > >> Here is a set of small independent patches that clean up or fix mino=
r things
> > >> across DMA slave drivers.
>=20
> Applied thanks
Thank you. You were faster than me, I was just about to send rebased
version.
--=20
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-07-15 10:21 ` Andy Shevchenko
@ 2013-07-15 9:59 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2013-07-15 9:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Shawn Guo, Stephen Warren, linux-kernel@vger.kernel.org,
Andy Shevchenko, Andy Shevchenko, Zhang Wei, Dan Williams,
linux-tegra, linuxppc-dev
On Mon, Jul 15, 2013 at 01:21:17PM +0300, Andy Shevchenko wrote:
> On Mon, 2013-07-15 at 15:07 +0530, Vinod Koul wrote:
> > On Thu, May 30, 2013 at 09:32:19PM +0300, Andy Shevchenko wrote:
> > > >> Here is a set of small independent patches that clean up or fix minor things
> > > >> across DMA slave drivers.
> >
> > Applied thanks
>
> Thank you. You were faster than me, I was just about to send rebased
> version.
:)
I suspected changes are trivial and it should apply or with slight modfications.
it did apply cleanly so no reason to delay applying on shiny new -rc1
For folks in this part of world, monday morning Linus drops the rc1 usually, so
get staright to it!
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-05-30 17:47 ` [PATCH 00/12] dma: various minor clean ups for slave drivers Vinod Koul
2013-05-30 18:32 ` Andy Shevchenko
@ 2013-06-01 0:09 ` Dan Williams
2013-07-15 9:33 ` Vinod Koul
2013-07-10 7:54 ` Andy Shevchenko
2 siblings, 1 reply; 10+ messages in thread
From: Dan Williams @ 2013-06-01 0:09 UTC (permalink / raw)
To: Vinod Koul
Cc: Shawn Guo, Stephen Warren, Linux Kernel Mailing List,
Andy Shevchenko, Zhang Wei, linux-tegra, linuxppc-dev
On Thu, May 30, 2013 at 10:47 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote:
>> Here is a set of small independent patches that clean up or fix minor things
>> across DMA slave drivers.
> The series looks fine. I am going to wait a day more and apply, pls speak up if
> you disagree and ack if you agree
Looks ok to me. Reminds we can probably take this one step further
and provide a generic implementation for the common case. It's just a
bit inconsistent though that some engines will poll the completion
handler (try to advance the state of the last completed cookie)
whereas others just assume things will be completed asynchronously.
--
Dan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-06-01 0:09 ` Dan Williams
@ 2013-07-15 9:33 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2013-07-15 9:33 UTC (permalink / raw)
To: Dan Williams
Cc: Shawn Guo, Stephen Warren, Linux Kernel Mailing List,
Andy Shevchenko, Zhang Wei, linux-tegra, linuxppc-dev
On Fri, May 31, 2013 at 05:09:51PM -0700, Dan Williams wrote:
> On Thu, May 30, 2013 at 10:47 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote:
> >> Here is a set of small independent patches that clean up or fix minor things
> >> across DMA slave drivers.
> > The series looks fine. I am going to wait a day more and apply, pls speak up if
> > you disagree and ack if you agree
>
> Looks ok to me. Reminds we can probably take this one step further
> and provide a generic implementation for the common case. It's just a
> bit inconsistent though that some engines will poll the completion
> handler (try to advance the state of the last completed cookie)
> whereas others just assume things will be completed asynchronously.
agree with that. These are the inconsistencies some of which are based on
hardware and some are user iterpretations...
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/12] dma: various minor clean ups for slave drivers
2013-05-30 17:47 ` [PATCH 00/12] dma: various minor clean ups for slave drivers Vinod Koul
2013-05-30 18:32 ` Andy Shevchenko
2013-06-01 0:09 ` Dan Williams
@ 2013-07-10 7:54 ` Andy Shevchenko
2 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2013-07-10 7:54 UTC (permalink / raw)
To: Vinod Koul
Cc: Shawn Guo, Stephen Warren, linux-kernel, Andy Shevchenko,
Zhang Wei, Dan Williams, linux-tegra, linuxppc-dev
On Thu, 2013-05-30 at 23:17 +0530, Vinod Koul wrote:=20
> On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote:
> > Here is a set of small independent patches that clean up or fix minor t=
hings
> > across DMA slave drivers.
> The series looks fine. I am going to wait a day more and apply, pls speak=
up if
> you disagree and ack if you agree
Kindly remind about this series.
>=20
> --
> ~Vinod
> >=20
> > Andy Shevchenko (12):
> > imx-sdma: remove useless variable
> > mxs-dma: remove useless variable
> > edma: no need to assign residue to 0 explicitly
> > ep93xx_dma: remove useless use of lock
> > fsldma: remove useless use of lock
> > mmp_pdma: remove useless use of lock
> > mpc512x_dma: remove useless use of lock
> > pch_dma: remove useless use of lock
> > tegra20-apb-dma: remove useless use of lock
> > ipu_idmac: re-use dma_cookie_status()
> > mmp_tdma: set cookies as well when asked for tx status
> > txx9dmac: return DMA_SUCCESS immediately from device_tx_status()
> >=20
> > drivers/dma/edma.c | 2 --
> > drivers/dma/ep93xx_dma.c | 10 +---------
> > drivers/dma/fsldma.c | 10 +---------
> > drivers/dma/imx-sdma.c | 9 +++------
> > drivers/dma/ipu/ipu_idmac.c | 5 +----
> > drivers/dma/mmp_pdma.c | 10 +---------
> > drivers/dma/mmp_tdma.c | 3 ++-
> > drivers/dma/mpc512x_dma.c | 10 +---------
> > drivers/dma/mxs-dma.c | 4 +---
> > drivers/dma/pch_dma.c | 9 +--------
> > drivers/dma/tegra20-apb-dma.c | 8 +++-----
> > drivers/dma/txx9dmac.c | 13 ++++++-------
> > 12 files changed, 21 insertions(+), 72 deletions(-)
> >=20
> > --=20
> > 1.8.2.rc0.22.gb3600c3
> >=20
>=20
--=20
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 10+ messages in thread