From: Scott Wood <scottwood@freescale.com>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.de,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [v1][PATCH 1/1] KVM: PPC: disable preemption when using hard_irq_disable()
Date: Wed, 10 Jul 2013 14:15:40 -0500 [thread overview]
Message-ID: <1373483740.8183.223@snotra> (raw)
In-Reply-To: <1373436139-27998-1-git-send-email-tiejun.chen@windriver.com> (from tiejun.chen@windriver.com on Wed Jul 10 01:02:19 2013)
On 07/10/2013 01:02:19 AM, Tiejun Chen wrote:
> We should ensure the preemption cannot occur while calling get_paca()
> insdide hard_irq_disable(), otherwise the paca_struct may be the
> wrong one just after. And btw, we may update timing stats in this =20
> case.
The soft-ee mechanism depends on accessing the PACA directly via r13 to =20
avoid this. We probably should be using inline asm to read was_enabled =20
rather than hoping the compiler doesn't do anything silly.
Plus what Alex said, regarding this patch specifically.
-Scott=
next parent reply other threads:[~2013-07-10 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373436139-27998-1-git-send-email-tiejun.chen@windriver.com>
2013-07-10 19:15 ` Scott Wood [this message]
2013-07-11 3:00 ` [v1][PATCH 1/1] KVM: PPC: disable preemption when using hard_irq_disable() tiejun.chen
2013-07-11 14:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373483740.8183.223@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).