From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu
Date: Fri, 12 Jul 2013 18:37:13 +1000 [thread overview]
Message-ID: <1373618233.19894.143.camel@pasglop> (raw)
In-Reply-To: <1373607402-21738-2-git-send-email-haokexin@gmail.com>
On Fri, 2013-07-12 at 13:36 +0800, Kevin Hao wrote:
> + /*
> + * If we support a HW FPU, we need to ensure the FP state
> + * if flushed into the thread_struct before attempting
> + * emulation
> + */
> +#ifdef CONFIG_PPC_FPU
> + flush_fp_to_thread(current);
> +#endif
> +
While at it, care to send a patch that defined an empty
flush_fp_to_thread() in the header instead ?
ie, switch_to.h
#ifdef CONFIG_PPC_FPU
extern void flush_fp_to_thread(struct task-struct *);
#else
static inline void flush_fp_to_thread(struct task-struct *) { };
#endif
And get rid of the ifdef's here (and elsewhere if any) ?
Thanks !
Cheers,
Ben.
next prev parent reply other threads:[~2013-07-12 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 5:36 [PATCH v2 0/2] powerpc/math-emu: two patches for the emulation of the FPU unimplemented instructions Kevin Hao
2013-07-12 5:36 ` [PATCH v2 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu Kevin Hao
2013-07-12 8:37 ` Benjamin Herrenschmidt [this message]
2013-07-14 8:29 ` Kevin Hao
2013-07-12 5:36 ` [PATCH v2 2/2] powerpc: introduce function emulate_math() Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373618233.19894.143.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).