From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AF1282C033F for ; Sat, 13 Jul 2013 09:06:49 +1000 (EST) Message-ID: <1373670396.19894.215.camel@pasglop> Subject: Re: [PATCH 2/2] powerpc/hibernate: add restore mmu context after resume From: Benjamin Herrenschmidt To: Scott Wood Date: Sat, 13 Jul 2013 09:06:36 +1000 In-Reply-To: <1373666090.8183.290@snotra> References: <1373666090.8183.290@snotra> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Wood Scott-B07421 , "anton@enomsg.org" , Wang Dongsheng-B40534 , "johannes@sipsolutions.net" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2013-07-12 at 16:54 -0500, Scott Wood wrote: > set_context() doesn't exist for hash MMUs. > > Whatever you do, please try actually building it on various targets, > including both 32 and 64 bits, and both hash and non-hash. And make > sure that whatever effect PPC32 was depending on switch_mmu_context > for > is preserved, including on non-booke. The right thing to do is probably to have the various tlb_* files provide a pair of save/restore functions that do the right thing for that specific MMU type. Ben.