From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
Viresh Kumar <viresh.kumar@linaro.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nick Piggin <npiggin@suse.de>,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: [PATCH 2/3] cpufreq: pmac64: re-estimate G5 cpufreq transition latency
Date: Tue, 23 Jul 2013 23:24:38 +0300 [thread overview]
Message-ID: <1374611079-28091-2-git-send-email-aaro.koskinen@iki.fi> (raw)
In-Reply-To: <1374611079-28091-1-git-send-email-aaro.koskinen@iki.fi>
The latency is in milliseconds scale rather than microseconds based on
measurements on iMac G5 and Xscale G5. The patch also enables to use
ondemand governor on the latter.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/cpufreq/pmac64-cpufreq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 674807d..f9e399b 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -85,7 +85,8 @@ static int (*g5_query_freq)(void);
static DEFINE_MUTEX(g5_switch_mutex);
-static unsigned long transition_latency;
+/* A conservative estimate, based on Xserve G5 and iMac G5 (iSight). */
+static const unsigned long transition_latency = 10 * NSEC_PER_MSEC;
#ifdef CONFIG_PMAC_SMU
@@ -499,7 +500,6 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpus)
g5_cpu_freqs[1].frequency = max_freq/2;
/* Set callbacks */
- transition_latency = 12000;
g5_switch_freq = g5_scom_switch_freq;
g5_query_freq = g5_scom_query_freq;
freq_method = "SCOM";
@@ -675,7 +675,6 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpus)
g5_cpu_freqs[1].frequency = min_freq;
/* Set callbacks */
- transition_latency = CPUFREQ_ETERNAL;
g5_switch_volt = g5_pfunc_switch_volt;
g5_switch_freq = g5_pfunc_switch_freq;
g5_query_freq = g5_pfunc_query_freq;
--
1.8.3.2
next prev parent reply other threads:[~2013-07-23 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 20:24 [PATCH 1/3] cpufreq: pmac64: speed up frequency switch Aaro Koskinen
2013-07-23 20:24 ` Aaro Koskinen [this message]
2013-07-24 5:34 ` [PATCH 2/3] cpufreq: pmac64: re-estimate G5 cpufreq transition latency Viresh Kumar
2013-07-24 10:18 ` Aaro Koskinen
2013-07-24 10:45 ` Viresh Kumar
2013-07-23 20:24 ` [PATCH 3/3] cpufreq: pmac64: enable cpufreq on iMac G5 (iSight) model Aaro Koskinen
2013-07-24 5:34 ` Viresh Kumar
2013-07-23 21:20 ` [PATCH 1/3] cpufreq: pmac64: speed up frequency switch Rafael J. Wysocki
2013-07-23 21:14 ` Benjamin Herrenschmidt
2013-08-12 1:07 ` Benjamin Herrenschmidt
2013-08-15 20:10 ` Aaro Koskinen
2013-08-15 22:14 ` Benjamin Herrenschmidt
2013-07-24 5:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374611079-28091-2-git-send-email-aaro.koskinen@iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=benh@kernel.crashing.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@suse.de \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).