linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: <hongbo.zhang@freescale.com>
Cc: devicetree@vger.kernel.org, vinod.koul@intel.com,
	linux-kernel@vger.kernel.org,
	Hongbo Zhang <hongbo.zhang@freescale.com>,
	djbw@fb.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 3/4] DMA: Freescale: update driver to support 8-channel DMA engine
Date: Wed, 24 Jul 2013 14:30:07 -0500	[thread overview]
Message-ID: <1374694207.15592.62@snotra> (raw)
In-Reply-To: <1374646870-5162-4-git-send-email-hongbo.zhang@freescale.com> (from hongbo.zhang@freescale.com on Wed Jul 24 01:21:08 2013)

On 07/24/2013 01:21:08 AM, hongbo.zhang@freescale.com wrote:
> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>=20
> This patch adds support to 8-channel DMA engine, thus the driver =20
> works for both
> the new 8-channel and the legacy 4-channel DMA engines.
>=20
> Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>
> ---
>  drivers/dma/Kconfig  |    9 +++++----
>  drivers/dma/fsldma.c |    9 ++++++---
>  drivers/dma/fsldma.h |    2 +-
>  3 files changed, 12 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 6825957..1b78272 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -89,14 +89,15 @@ config AT_HDMAC
>  	  Support the Atmel AHB DMA controller.
>=20
>  config FSL_DMA
> -	tristate "Freescale Elo and Elo Plus DMA support"
> +	tristate "Freescale Elo series DMA support"
>  	depends on FSL_SOC
>  	select DMA_ENGINE
>  	select ASYNC_TX_ENABLE_CHANNEL_SWITCH
>  	---help---
> -	  Enable support for the Freescale Elo and Elo Plus DMA =20
> controllers.
> -	  The Elo is the DMA controller on some 82xx and 83xx parts, =20
> and the
> -	  Elo Plus is the DMA controller on 85xx and 86xx parts.
> +	  Enable support for the Freescale Elo series DMA controllers.
> +	  The Elo is the DMA controller on some mpc82xx and mpc83xx =20
> parts, the
> +	  EloPlus is on mpc85xx and mpc86xx and Pxxx parts, and the =20
> Elo3 is on
> +	  some Txxx and Bxxx parts. Look up user manuals for details =20
> anyway.

The user manuals do not use the "elo" terminology.  I also don't =20
understand the tone you're trying to convey with "anyway".

-Scott=

  reply	other threads:[~2013-07-24 19:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24  6:21 [PATCH v5 0/4] DMA: Freescale: Add support for 8-channel DMA engine hongbo.zhang
2013-07-24  6:21 ` [PATCH v5 1/4] DMA: Freescale: revise device tree binding document hongbo.zhang
2013-07-24  6:21 ` [PATCH v5 2/4] DMA: Freescale: Add new 8-channel DMA engine device tree nodes hongbo.zhang
2013-07-24 19:29   ` Scott Wood
2013-07-24  6:21 ` [PATCH v5 3/4] DMA: Freescale: update driver to support 8-channel DMA engine hongbo.zhang
2013-07-24 19:30   ` Scott Wood [this message]
2013-07-24  6:21 ` [PATCH v5 4/4] DMA: Freescale: eliminate a compiling warning hongbo.zhang
2013-07-24 19:33   ` Scott Wood
2013-07-25  2:46     ` Hongbo Zhang
2013-07-24  6:34 ` [PATCH v5 0/4] DMA: Freescale: Add support for 8-channel DMA engine Li Yang
2013-07-24  6:47 ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374694207.15592.62@snotra \
    --to=scottwood@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djbw@fb.com \
    --cc=hongbo.zhang@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).