From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) (using SSLv3 with cipher DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 69D992C00BE for ; Tue, 30 Jul 2013 05:34:26 +1000 (EST) Message-ID: <1375126464.2075.46.camel@joe-AO722> Subject: Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN From: Joe Perches To: "Rafael J. Wysocki" Date: Mon, 29 Jul 2013 12:34:24 -0700 In-Reply-To: <2929374.frUlkyTFNL@vostro.rjw.lan> References: <2929374.frUlkyTFNL@vostro.rjw.lan> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Cc: Steve Glendinning , Samuel Ortiz , linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Vitaly Bordug , Len Brown , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Mauro Carvalho Chehab List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote: > On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote: > > It's convenient to have ethernet mac addresses use > > ETH_ALEN to be able to grep for them a bit easier and > > also to ensure that the addresses are __aligned(2). [] > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h [] > > @@ -44,6 +44,8 @@ [] > > +#include > > + [] > > @@ -605,7 +607,7 @@ struct acpi_ibft_nic { [] > > - u8 mac_address[6]; > > + u8 mac_address[ETH_ALEN]; > Please don't touch this file. > > It comes from a code base outside of the kernel and should be kept in sync with > the upstream. Which files in include/acpi have this characteristic? Perhaps an include/acpi/README is appropriate.