linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Fionnuala Gunter <fin@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor
Date: Sat, 03 Aug 2013 07:09:01 +1000	[thread overview]
Message-ID: <1375477741.15999.23.camel@pasglop> (raw)
In-Reply-To: <1375477090.32477.10.camel@what-is-leg>

On Fri, 2013-08-02 at 15:58 -0500, Fionnuala Gunter wrote:
> The chaining value from co-processor was not being saved. This value is
> needed because it is used as the IV, for example by cts i.e.
> cts(cbc(aes)).
> 
> Signed-off-by: Fionnuala Gunter <fin@linux.vnet.ibm.com>
> Signed-off-by: Marcelo Cerri <mhcerri@linux.vnet.ibm.com>

So now you guys are sending the patch to linuxppc-dev and not the crypto
list ..

I need to understand things better here. Any reason why those drivers
aren't handled by the crypto maintainer ?

Ben.

> ---
>  drivers/crypto/nx/nx-aes-cbc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/nx/nx-aes-cbc.c
> b/drivers/crypto/nx/nx-aes-cbc.c
> index 35d483f..a2f99a9 100644
> --- a/drivers/crypto/nx/nx-aes-cbc.c
> +++ b/drivers/crypto/nx/nx-aes-cbc.c
> @@ -95,6 +95,7 @@ static int cbc_aes_nx_crypt(struct blkcipher_desc
> *desc,
>         if (rc)
>                 goto out;
> 
> +       memcpy(desc->info, csbcpb->cpb.aes_cbc.cv, AES_BLOCK_SIZE);
>         atomic_inc(&(nx_ctx->stats->aes_ops));
>         atomic64_add(csbcpb->csb.processed_byte_count,
>                      &(nx_ctx->stats->aes_bytes));

  reply	other threads:[~2013-08-02 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 20:58 [PATCH] drivers/crypto/nx: saves chaining value from co-processor Fionnuala Gunter
2013-08-02 21:09 ` Benjamin Herrenschmidt [this message]
2013-08-02 21:55   ` Fionnuala Gunter
2013-08-02 21:59     ` Benjamin Herrenschmidt
2013-08-02 22:16       ` Fionnuala Gunter
2013-08-05  2:21         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375477741.15999.23.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=fin@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).