From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from co9outboundpool.messaging.microsoft.com (co9ehsobe001.messaging.microsoft.com [207.46.163.24]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0C5CC2C01BC for ; Tue, 6 Aug 2013 07:11:19 +1000 (EST) Message-ID: <1375737065.13074.58.camel@snotra.buserror.net> Subject: Re: [PATCH] Add device file bindings for MAPLE From: Scott Wood To: Kumar Gala Date: Mon, 5 Aug 2013 16:11:05 -0500 In-Reply-To: <5C32ABF4-ECC3-4F1C-82D0-EA3AD9053575@kernel.crashing.org> References: <1375354963-11219-1-git-send-email-shaveta@freescale.com> <5C32ABF4-ECC3-4F1C-82D0-EA3AD9053575@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: Shaveta Leekha , devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2013-08-01 at 11:05 -0500, Kumar Gala wrote: > On Aug 1, 2013, at 6:02 AM, Shaveta Leekha wrote: > > > Signed-off-by: Shaveta Leekha > > --- > > .../devicetree/bindings/powerpc/fsl/maple.txt | 30 ++++++++++++++++++++ > > 1 files changed, 30 insertions(+), 0 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/maple.txt > > > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/maple.txt b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt > > new file mode 100644 > > index 0000000..da51c5f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt > > @@ -0,0 +1,30 @@ > > +* Freescale MAPLE Multi Accelerator Platform Engine Baseband 3 > > + (MAPLE-B3)device nodes > > + > > +Supported chips: > > +Example: B4860 > > + > > +Required properties: > > + > > +- compatible: Should contain "fsl,maple-b3-liodn" as the value > > + This identifies Multi Accelerator Platform Engine > > + Baseband 3 block.This representation is required > > + for doing the PAMU/LIODN programming on the Linux side. > > This compatible makes no sense, we shouldn't be marking a full HW block with some name that is just intended for LIODN convenance. The point is we're not describing the whole block here, because the rest of the block is owned by an external entity (the DSP cores). > Is this version 3 of the block? If so a name like "fsl,maple-v3" or "fsl,maple-v3.0" would be more appropriate. > > - k > > > + > > +- reg: offset and length of the register set for the device > > + > > +Devices that have LIODNs need to specify links to the parent PAMU controller > > +(the actual PAMU controller that this device is connected to) and a pointer to > > +the LIODN register, if applicable. > > > Does Maple not have any IRQs associated with it? maple-liodn doesn't. -Scott