linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Lutz Jaenicke <ljaenicke@innominate.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] net/fsl_pq_mdio: fix handling of TBIPA register
Date: Tue, 6 Aug 2013 18:10:55 -0500	[thread overview]
Message-ID: <1375830655.5600.24.camel@snotra.buserror.net> (raw)
In-Reply-To: <1375379355-18594-1-git-send-email-ljaenicke@innominate.com>

On Thu, 2013-08-01 at 19:49 +0200, Lutz Jaenicke wrote:
> The TBIPA register is part of gianfar's full register set. When starting
> from the MII registers, the start address of struct gfar needs to
> be determined via container_of().
> Experienced with mpc8313 and "fsl,gianfar-mdio" device tree entries.
> 
> Signed-off-by: Lutz Jaenicke <ljaenicke@innominate.com>
> ---
>  drivers/net/ethernet/freescale/fsl_pq_mdio.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> index c93a056..9485fdb 100644
> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> @@ -193,7 +193,8 @@ static int fsl_pq_mdio_reset(struct mii_bus *bus)
>   */
>  static uint32_t __iomem *get_gfar_tbipa(void __iomem *p)
>  {
> -	struct gfar __iomem *enet_regs = p;
> +	struct gfar __iomem *enet_regs = 
> +		container_of(p, struct gfar, gfar_mii_regs);
>  
>  	return &enet_regs->tbipa;
>  }

Please send this to the netdev list/maintainer.

-Scott

  reply	other threads:[~2013-08-06 23:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 17:49 [PATCH] net/fsl_pq_mdio: fix handling of TBIPA register Lutz Jaenicke
2013-08-06 23:10 ` Scott Wood [this message]
2013-08-06 23:55   ` Scott Wood
2013-08-07 14:22     ` Lutz Jaenicke
2013-08-07 21:26       ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375830655.5600.24.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ljaenicke@innominate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).