From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Olof Johansson <olof@lixom.net>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12
Date: Wed, 14 Aug 2013 21:37:07 +1000 [thread overview]
Message-ID: <1376480227.4255.66.camel@pasglop> (raw)
In-Reply-To: <520B5584.7030608@arm.com>
On Wed, 2013-08-14 at 11:01 +0100, Sudeep KarkadaNagesha wrote:
> Yes this doesn't cover the historical "ibm,ppc-interrupt-server#s",
> for
> which we can have PPC specific wrapper above the generic one i.e. get
> the cpu node and then parse for thread id under custom property.
A wrapper is wrong. I don't want to have to have all ppc callers to use
a different function.
As I said, just make a generic one that returns a thread ID, ie, same
signature as the powerpc one. Make it weak, we can override it in
powerpc-land, or we can move the ibm,ppc-interrupt-server#s handling
into the generic one, it won't hurt, but leave the thread_id return
there, it doesn't hurt it will come in handy in a few cases without
causing code duplication.
Cheers,
Ben.
next prev parent reply other threads:[~2013-08-14 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5208E2D3.7060005@arm.com>
[not found] ` <3356439.a21MloFP7n@vostro.rjw.lan>
2013-08-13 15:40 ` [GIT PULL] DT/core: cpu_ofnode updates for v3.12 Sudeep KarkadaNagesha
2013-08-13 18:29 ` Sudeep KarkadaNagesha
2013-08-13 21:07 ` Benjamin Herrenschmidt
2013-08-14 10:01 ` Sudeep KarkadaNagesha
2013-08-14 11:37 ` Benjamin Herrenschmidt [this message]
2013-08-14 13:21 ` Sudeep KarkadaNagesha
2013-08-14 22:57 ` Benjamin Herrenschmidt
2013-08-14 12:53 ` Rob Herring
2013-08-14 13:27 ` Sudeep KarkadaNagesha
2013-08-13 18:37 ` Michal Simek
2013-08-14 8:41 ` Sudeep KarkadaNagesha
2013-08-13 18:44 ` Rob Herring
2013-08-13 19:45 ` Rafael J. Wysocki
2013-08-13 21:09 ` Benjamin Herrenschmidt
2013-08-14 9:23 ` Sudeep KarkadaNagesha
2013-08-13 21:08 ` Benjamin Herrenschmidt
2013-08-13 21:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376480227.4255.66.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Sudeep.KarkadaNagesha@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).