From: Toshi Kani <toshi.kani@hp.com>
To: rjw@sisk.pl
Cc: fenghua.yu@intel.com, bp@suse.de, Toshi Kani <toshi.kani@hp.com>,
gregkh@linuxfoundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
isimatu.yasuaki@jp.fujitsu.com, mingo@redhat.com,
srivatsa.bhat@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com,
tglx@linutronix.de, hpa@linux.intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2 1/4] hotplug, x86: Fix online state in cpu0 debug interface
Date: Thu, 29 Aug 2013 18:22:06 -0600 [thread overview]
Message-ID: <1377822129-4143-2-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1377822129-4143-1-git-send-email-toshi.kani@hp.com>
_debug_hotplug_cpu() is a debug interface that puts cpu0 offline during
boot-up when CONFIG_DEBUG_HOTPLUG_CPU0 is set. After cpu0 is put offline
in this interface, however, /sys/devices/system/cpu/cpu0/online still
shows 1 (online).
This patch fixes _debug_hotplug_cpu() to update dev->offline when CPU
online/offline operation succeeded.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
arch/x86/kernel/topology.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
index 6e60b5f..5823bbd 100644
--- a/arch/x86/kernel/topology.c
+++ b/arch/x86/kernel/topology.c
@@ -72,16 +72,19 @@ int __ref _debug_hotplug_cpu(int cpu, int action)
ret = cpu_down(cpu);
if (!ret) {
pr_info("CPU %u is now offline\n", cpu);
+ dev->offline = true;
kobject_uevent(&dev->kobj, KOBJ_OFFLINE);
} else
pr_debug("Can't offline CPU%d.\n", cpu);
break;
case 1:
ret = cpu_up(cpu);
- if (!ret)
+ if (!ret) {
+ dev->offline = false;
kobject_uevent(&dev->kobj, KOBJ_ONLINE);
- else
+ } else {
pr_debug("Can't online CPU%d.\n", cpu);
+ }
break;
default:
ret = -EINVAL;
next prev parent reply other threads:[~2013-08-30 0:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 0:22 [PATCH v2 0/4] Unify CPU hotplug lock interface Toshi Kani
2013-08-30 0:22 ` Toshi Kani [this message]
2013-08-31 0:24 ` [PATCH v2 1/4] hotplug, x86: Fix online state in cpu0 debug interface Rafael J. Wysocki
2013-08-30 0:22 ` [PATCH v2 2/4] hotplug, x86: Add hotplug lock to missing places Toshi Kani
2013-08-30 0:22 ` [PATCH v2 3/4] hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86 Toshi Kani
2013-08-30 0:22 ` [PATCH v2 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock() Toshi Kani
2013-09-25 8:27 ` Rafael J. Wysocki
2013-09-25 20:44 ` Toshi Kani
2013-08-30 2:44 ` [PATCH v2 0/4] Unify CPU hotplug lock interface Yasuaki Ishimatsu
2013-08-30 12:14 ` Rafael J. Wysocki
2013-08-30 14:35 ` Toshi Kani
2013-08-30 14:33 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377822129-4143-2-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@linux.intel.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).