From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Work around gcc miscompilation of __pa() on 64-bit
Date: Mon, 02 Sep 2013 15:06:16 +1000 [thread overview]
Message-ID: <1378098376.3978.17.camel@pasglop> (raw)
In-Reply-To: <20130902023110.GV3430@bubble.grove.modra.org>
On Mon, 2013-09-02 at 12:01 +0930, Alan Modra wrote:
> > No, if you don't have a reloc that can represent this, then the proper
> > fix is to use the existing relocs to load the original symbol address
> > into a register, then *generate* the appropriate 64-bit addition on top
> > of it.
>
> I already have a gcc fix to do exactly that. My "proper fix" comment
> was more to do with the general case. For example, when linking a
> huge object that overflows _HA relocs right now we silently generate
> bad code.
Ah that is nice indeed :-) In that case I assume we can't have the offset
itself be part of the TOC :-) Chicken or egg ?
Not sure what's the right fix here is, we don't want to always reserve
enough instructions "space" to do a full 64-bit offset load...
Ben.
prev parent reply other threads:[~2013-09-02 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 6:07 [PATCH] powerpc: Work around gcc miscompilation of __pa() on 64-bit Paul Mackerras
2013-08-27 7:12 ` Alan Modra
2013-08-27 9:03 ` Paul Mackerras
2013-09-01 23:59 ` Benjamin Herrenschmidt
2013-09-02 2:31 ` Alan Modra
2013-09-02 5:06 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378098376.3978.17.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).