From: Scott Wood <scottwood@freescale.com>
To: Xie Xiaobo <X.Xie@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 1/2] powerpc/85xx: Add QE common init functions
Date: Wed, 4 Sep 2013 11:26:59 -0500 [thread overview]
Message-ID: <1378312019.12204.21.camel@snotra.buserror.net> (raw)
In-Reply-To: <1378116699-18826-1-git-send-email-X.Xie@freescale.com>
On Mon, 2013-09-02 at 18:11 +0800, Xie Xiaobo wrote:
> Define two QE init functions in common file, and avoid
> the same codes being duplicated in board files.
>
> Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
> ---
> V3 -> V2: Nochange
>
> arch/powerpc/platforms/85xx/common.c | 47 +++++++++++++++++++++++++++++++++++
> arch/powerpc/platforms/85xx/mpc85xx.h | 8 ++++++
> 2 files changed, 55 insertions(+)
Don't just copy it; remove it from the place you copied from and have
that code call the common version.
-Scott
next prev parent reply other threads:[~2013-09-04 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:11 [PATCH V3 1/2] powerpc/85xx: Add QE common init functions Xie Xiaobo
2013-09-02 10:11 ` [PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support Xie Xiaobo
2013-09-04 16:25 ` Scott Wood
2013-09-06 10:01 ` Xie Xiaobo-R63061
2013-09-06 15:25 ` Scott Wood
2013-09-10 9:28 ` Xie Xiaobo-R63061
2013-09-09 3:57 ` Liu Shengzhou-B36685
2013-09-04 16:26 ` Scott Wood [this message]
2013-09-06 9:52 ` [PATCH V3 1/2] powerpc/85xx: Add QE common init functions Xie Xiaobo-R63061
2013-09-06 15:24 ` Scott Wood
2013-09-10 8:55 ` Xie Xiaobo-R63061
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378312019.12204.21.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=X.Xie@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).