From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org,
Jia Hongtao <hongtao.jia@freescale.com>,
B07421@freescale.com
Subject: Re: [PATCH V2 2/2] powerpc/85xx: workaround for chips with MSI hardware errata
Date: Thu, 5 Sep 2013 13:37:56 -0500 [thread overview]
Message-ID: <1378406276.12204.101.camel@snotra.buserror.net> (raw)
In-Reply-To: <C12D1FFD-4D98-48C1-8681-54489600F722@kernel.crashing.org>
On Thu, 2013-09-05 at 13:34 -0500, Kumar Gala wrote:
> On Apr 2, 2013, at 9:03 PM, Jia Hongtao wrote:
> > + msi->feature |= MSI_HW_ERRATA_ENDIAN;
> > + }
> > +
> > /*
> > * Remember the phandle, so that we can match with any PCI nodes
> > * that have an "fsl,msi" property.
> > diff --git a/arch/powerpc/sysdev/fsl_msi.h b/arch/powerpc/sysdev/fsl_msi.h
> > index 8225f86..7389e8e 100644
> > --- a/arch/powerpc/sysdev/fsl_msi.h
> > +++ b/arch/powerpc/sysdev/fsl_msi.h
> > @@ -25,6 +25,8 @@
> > #define FSL_PIC_IP_IPIC 0x00000002
> > #define FSL_PIC_IP_VMPIC 0x00000003
> >
> > +#define MSI_HW_ERRATA_ENDIAN 0x00000010
> > +
>
> Why does this need to be in the header, why not just have it in the .c only
Didn't you ask this last time around? :-)
This flag is part of the same numberspace as FSL_PIC_IP_xxx and thus
should be defined in the same place.
-Scott
next prev parent reply other threads:[~2013-09-05 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 2:03 [PATCH V3 1/2] powerpc/MPIC: Add get_version API both for internal and external use Jia Hongtao
2013-04-03 2:03 ` [PATCH V2 2/2] powerpc/85xx: workaround for chips with MSI hardware errata Jia Hongtao
2013-06-28 2:28 ` [V2,2/2] " Scott Wood
2013-07-01 9:36 ` Jia Hongtao-B38951
2013-09-05 4:00 ` Jia Hongtao-B38951
2013-09-05 17:57 ` Scott Wood
2013-09-06 3:19 ` Jia Hongtao-B38951
2013-09-05 18:34 ` [PATCH V2 2/2] " Kumar Gala
2013-09-05 18:37 ` Scott Wood [this message]
2013-09-06 15:01 ` Kumar Gala
2013-09-06 15:36 ` Scott Wood
2013-09-06 16:11 ` Kumar Gala
2013-04-03 16:17 ` [PATCH V3 1/2] powerpc/MPIC: Add get_version API both for internal and external use Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378406276.12204.101.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=hongtao.jia@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).