* [PATCH] powerpc: Export cpu_to_chip_id() to fix build error
@ 2013-09-10 1:37 Guenter Roeck
2013-09-10 22:03 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2013-09-10 1:37 UTC (permalink / raw)
To: linuxppc-dev
Cc: linux-kernel, Vasant Hegde, Paul Mackerras, Shivaprasad G Bhat,
Guenter Roeck
powerpc allmodconfig build fails with:
ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
information available to userspace).
Export the missing symbol.
Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/powerpc/kernel/smp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 442d8e2..8e59abc 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
of_node_put(np);
return of_get_ibm_chip_id(np);
}
+EXPORT_SYMBOL(cpu_to_chip_id);
/* Helper routines for cpu to core mapping */
int cpu_core_index_of_thread(int cpu)
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Export cpu_to_chip_id() to fix build error
2013-09-10 1:37 [PATCH] powerpc: Export cpu_to_chip_id() to fix build error Guenter Roeck
@ 2013-09-10 22:03 ` Benjamin Herrenschmidt
2013-09-11 8:00 ` Vasant Hegde
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2013-09-10 22:03 UTC (permalink / raw)
To: Guenter Roeck
Cc: Vasant Hegde, Paul Mackerras, linuxppc-dev, linux-kernel,
Shivaprasad G Bhat
On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote:
> powerpc allmodconfig build fails with:
>
> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
>
> The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
> information available to userspace).
Thanks, I'll send that to Linus asap.
Ben.
> Export the missing symbol.
>
> Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/powerpc/kernel/smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 442d8e2..8e59abc 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
> of_node_put(np);
> return of_get_ibm_chip_id(np);
> }
> +EXPORT_SYMBOL(cpu_to_chip_id);
>
> /* Helper routines for cpu to core mapping */
> int cpu_core_index_of_thread(int cpu)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Export cpu_to_chip_id() to fix build error
2013-09-10 22:03 ` Benjamin Herrenschmidt
@ 2013-09-11 8:00 ` Vasant Hegde
0 siblings, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2013-09-11 8:00 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Shivaprasad G Bhat, linuxppc-dev, Paul Mackerras, linux-kernel,
Guenter Roeck
On 09/11/2013 03:33 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote:
>> powerpc allmodconfig build fails with:
>>
>> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
>>
>> The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
>> information available to userspace).
>
> Thanks, I'll send that to Linus asap.
>
Verified on today's Linus tree. This issue is fixed.
Thanks a lot.
-Vasant
> Ben.
>
>> Export the missing symbol.
>>
>> Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
>> Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/powerpc/kernel/smp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
>> index 442d8e2..8e59abc 100644
>> --- a/arch/powerpc/kernel/smp.c
>> +++ b/arch/powerpc/kernel/smp.c
>> @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
>> of_node_put(np);
>> return of_get_ibm_chip_id(np);
>> }
>> +EXPORT_SYMBOL(cpu_to_chip_id);
>>
>> /* Helper routines for cpu to core mapping */
>> int cpu_core_index_of_thread(int cpu)
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-11 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 1:37 [PATCH] powerpc: Export cpu_to_chip_id() to fix build error Guenter Roeck
2013-09-10 22:03 ` Benjamin Herrenschmidt
2013-09-11 8:00 ` Vasant Hegde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).