* [PATCH 1/3] powerpc: export cpu_to_chip_id
@ 2013-09-10 16:38 Vladimir Murzin
2013-09-11 6:37 ` Vasant Hegde
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Murzin @ 2013-09-10 16:38 UTC (permalink / raw)
To: linuxppc-dev; +Cc: chenhui.zhao, Vladimir Murzin, paulus, srivatsa.bhat, tglx
While cross-building for PPC64 I've got
ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
mtip32xx refer to topology_physical_package_id, which stands for
cpu_to_chip-id.
Make cpu_to_chip-id (and topology_physical_package_id) available for
external users.
Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
---
arch/powerpc/kernel/smp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 442d8e2..1d9c1c2 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
of_node_put(np);
return of_get_ibm_chip_id(np);
}
+EXPORT_SYMBOL_GPL(cpu_to_chip_id);
/* Helper routines for cpu to core mapping */
int cpu_core_index_of_thread(int cpu)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] powerpc: export cpu_to_chip_id
2013-09-10 16:38 [PATCH 1/3] powerpc: export cpu_to_chip_id Vladimir Murzin
@ 2013-09-11 6:37 ` Vasant Hegde
2013-09-11 16:03 ` Vladimir Murzin
0 siblings, 1 reply; 3+ messages in thread
From: Vasant Hegde @ 2013-09-11 6:37 UTC (permalink / raw)
To: Vladimir Murzin; +Cc: paulus, tglx, linuxppc-dev, chenhui.zhao, srivatsa.bhat
On 09/10/2013 10:08 PM, Vladimir Murzin wrote:
> While cross-building for PPC64 I've got
>
Vladimir,
Below commit ID fixes this issue.
commit 256588fda10f2a712631f8a4e72641a66adebdb8
Author: Guenter Roeck <linux@roeck-us.net>
Date: Mon Sep 9 18:37:56 2013 -0700
powerpc: Export cpu_to_chip_id() to fix build error
-Vasant
> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
>
> mtip32xx refer to topology_physical_package_id, which stands for
> cpu_to_chip-id.
>
> Make cpu_to_chip-id (and topology_physical_package_id) available for
> external users.
>
> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> ---
> arch/powerpc/kernel/smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 442d8e2..1d9c1c2 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
> of_node_put(np);
> return of_get_ibm_chip_id(np);
> }
> +EXPORT_SYMBOL_GPL(cpu_to_chip_id);
>
> /* Helper routines for cpu to core mapping */
> int cpu_core_index_of_thread(int cpu)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] powerpc: export cpu_to_chip_id
2013-09-11 6:37 ` Vasant Hegde
@ 2013-09-11 16:03 ` Vladimir Murzin
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir Murzin @ 2013-09-11 16:03 UTC (permalink / raw)
To: Vasant Hegde; +Cc: paulus, tglx, linuxppc-dev, chenhui.zhao, srivatsa.bhat
On Wed, Sep 11, 2013 at 12:07:45PM +0530, Vasant Hegde wrote:
> On 09/10/2013 10:08 PM, Vladimir Murzin wrote:
> > While cross-building for PPC64 I've got
> >
> Vladimir,
>
> Below commit ID fixes this issue.
Great! For whatever reason I thought _GPL is default policy for exported
symbols... but, never mind ;)
Sorry for the noise
Vladimir
>
> commit 256588fda10f2a712631f8a4e72641a66adebdb8
> Author: Guenter Roeck <linux@roeck-us.net>
> Date: Mon Sep 9 18:37:56 2013 -0700
>
> powerpc: Export cpu_to_chip_id() to fix build error
>
> -Vasant
>
> > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
> >
> > mtip32xx refer to topology_physical_package_id, which stands for
> > cpu_to_chip-id.
> >
> > Make cpu_to_chip-id (and topology_physical_package_id) available for
> > external users.
> >
> > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> > ---
> > arch/powerpc/kernel/smp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> > index 442d8e2..1d9c1c2 100644
> > --- a/arch/powerpc/kernel/smp.c
> > +++ b/arch/powerpc/kernel/smp.c
> > @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
> > of_node_put(np);
> > return of_get_ibm_chip_id(np);
> > }
> > +EXPORT_SYMBOL_GPL(cpu_to_chip_id);
> >
> > /* Helper routines for cpu to core mapping */
> > int cpu_core_index_of_thread(int cpu)
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-11 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 16:38 [PATCH 1/3] powerpc: export cpu_to_chip_id Vladimir Murzin
2013-09-11 6:37 ` Vasant Hegde
2013-09-11 16:03 ` Vladimir Murzin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).