linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support
@ 2013-09-11  6:58 Prabhakar Kushwaha
  2013-09-11 23:41 ` Scott Wood
  0 siblings, 1 reply; 4+ messages in thread
From: Prabhakar Kushwaha @ 2013-09-11  6:58 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: scottwood, Priyanka Jain, Poonam Aggrwal, Prabhakar Kushwaha

 Add support for T104x board in board file t104x_qds.c, It is common for
 both T1040 and T1042 as they share same QDS board.

 T1040QDS board Overview
 -----------------------
 - SERDES Connections, 8 lanes supporting:
      =E2=80=94 PCI Express: supporting Gen 1 and Gen 2;
      =E2=80=94 SGMII
      =E2=80=94 QSGMII
      =E2=80=94 SATA 2.0
      =E2=80=94 Aurora debug with dedicated connectors (T1040 only)
 - DDR Controller
     - Supports rates of up to 1600 MHz data-rate
     - Supports one DDR3LP UDIMM/RDIMMs, of single-, dual- or quad-rank t=
ypes.
 -IFC/Local Bus
     - NAND flash: 8-bit, async, up to 2GB.
     - NOR: 8-bit or 16-bit, non-multiplexed, up to 512MB
     - GASIC: Simple (minimal) target within Qixis FPGA
     - PromJET rapid memory download support
 - Ethernet
     - Two on-board RGMII 10/100/1G ethernet ports.
     - PHY #0 remains powered up during deep-sleep (T1040 only)
 - QIXIS System Logic FPGA
 - Clocks
     - System and DDR clock (SYSCLK, =E2=80=9CDDRCLK=E2=80=9D)
     - SERDES clocks
 - Power Supplies
 - Video
     - DIU supports video at up to 1280x1024x32bpp
 - USB
     - Supports two USB 2.0 ports with integrated PHYs
     =E2=80=94 Two type A ports with 5V@1.5A per port.
     =E2=80=94 Second port can be converted to OTG mini-AB
 - SDHC
     - SDHC port connects directly to an adapter card slot, featuring:
     - Supporting SD slots for: SD, SDHC (1x, 4x, 8x) and/or MMC
     =E2=80=94 Supporting eMMC memory devices
 - SPI
    -  On-board support of 3 different devices and sizes
 - Other IO
    - Two Serial ports
    - ProfiBus port
    - Four I2C ports

 Add T104xQDS support in Kconfig and Makefile. Also create device tree.

Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.=
git

TODO: Add noded for ethernet and board stuff

 arch/powerpc/boot/dts/t1040qds.dts      |  201 +++++++++++++++++++++++++=
++++++
 arch/powerpc/boot/dts/t1042qds.dts      |  201 +++++++++++++++++++++++++=
++++++
 arch/powerpc/platforms/85xx/Kconfig     |   20 +++
 arch/powerpc/platforms/85xx/Makefile    |    1 +
 arch/powerpc/platforms/85xx/t104x_qds.c |  102 ++++++++++++++++
 5 files changed, 525 insertions(+)
 create mode 100644 arch/powerpc/boot/dts/t1040qds.dts
 create mode 100644 arch/powerpc/boot/dts/t1042qds.dts
 create mode 100644 arch/powerpc/platforms/85xx/t104x_qds.c

diff --git a/arch/powerpc/boot/dts/t1040qds.dts b/arch/powerpc/boot/dts/t=
1040qds.dts
new file mode 100644
index 0000000..cea5632
--- /dev/null
+++ b/arch/powerpc/boot/dts/t1040qds.dts
@@ -0,0 +1,201 @@
+/*
+ * T1040QDS Device Tree Source
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions ar=
e met:
+ *     * Redistributions of source code must retain the above copyright
+ *	 notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyrig=
ht
+ *	 notice, this list of conditions and the following disclaimer in the
+ *	 documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *	 names of its contributors may be used to endorse or promote products
+ *	 derived from this software without specific prior written permission=
.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of th=
e
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMP=
LIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AR=
E
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR A=
NY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DA=
MAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SE=
RVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUS=
ED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR=
 TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE=
 OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "fsl/t104xsi-pre.dtsi"
+
+/ {
+	model =3D "fsl,T1040QDS";
+	compatible =3D "fsl,T1040QDS";
+	#address-cells =3D <2>;
+	#size-cells =3D <2>;
+	interrupt-parent =3D <&mpic>;
+
+	aliases {
+		 /* TODO */
+		};
+
+	ifc: localbus@ffe124000 {
+		reg =3D <0xf 0xfe124000 0 0x2000>;
+		ranges =3D <0 0 0xf 0xe8000000 0x08000000
+			  2 0 0xf 0xff800000 0x00010000
+			  3 0 0xf 0xffdf0000 0x00008000>;
+
+		nor@0,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "cfi-flash";
+			reg =3D <0x0 0x0 0x8000000>;
+
+			bank-width =3D <2>;
+			device-width =3D <1>;
+		};
+
+		nand@2,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "fsl,ifc-nand";
+			reg =3D <0x2 0x0 0x10000>;
+
+			partition@0 {
+				/* This location must not be altered  */
+				/* 1MB for u-boot Bootloader Image */
+				reg =3D <0x0 0x00100000>;
+				label =3D "NAND U-Boot Image";
+				read-only;
+			};
+
+			partition@100000 {
+				/* 1MB for DTB Image */
+				reg =3D <0x00100000 0x00100000>;
+				label =3D "NAND DTB Image";
+			};
+
+			partition@200000 {
+				/* 10MB for Linux Kernel Image */
+				reg =3D <0x00200000 0x00A00000>;
+				label =3D "NAND Linux Kernel Image";
+			};
+
+			partition@C00000 {
+				/* 500MB for Root file System Image */
+				reg =3D <0x00c00000 0x1F400000>;
+				label =3D "NAND RFS Image";
+			};
+		};
+
+		board-control@3,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "fsl,tetra-fpga", "fsl,fpga-qixis";
+			reg =3D <3 0 0x300>;
+		};
+	};
+
+	memory {
+		device_type =3D "memory";
+	};
+
+	dcsr: dcsr@f00000000 {
+		ranges =3D <0x00000000 0xf 0x00000000 0x01072000>;
+	};
+
+	soc: soc@ffe000000 {
+		ranges =3D <0x00000000 0xf 0xfe000000 0x1000000>;
+		reg =3D <0xf 0xfe000000 0 0x00001000>;
+		spi@110000 {
+			flash@0 {
+				#address-cells =3D <1>;
+				#size-cells =3D <1>;
+				compatible =3D "micron,n25q512a";
+				reg =3D <0>;
+				spi-max-frequency =3D <10000000>; /* input clock */
+			};
+		};
+
+		i2c@118000 {
+                        pca9547@77 {
+                                compatible =3D "philips,pca9547";
+                                reg =3D <0x77>;
+                        };
+                       rtc@68 {
+                                compatible =3D "dallas,ds3232";
+                                reg =3D <0x68>;
+                                interrupts =3D <0x1 0x1 0 0>;
+                        };
+		};
+
+	};
+
+	pci0: pcie@ffe240000 {
+		reg =3D <0xf 0xfe240000 0 0x10000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci1: pcie@ffe250000 {
+		reg =3D <0xf 0xfe250000 0 0x10000>;
+		ranges =3D <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x10000000
+			  0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci2: pcie@ffe260000 {
+		reg =3D <0xf 0xfe260000 0 0x1000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci3: pcie@ffe270000 {
+		reg =3D <0xf 0xfe270000 0 0x10000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x60000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+};
+
+/include/ "fsl/t1040si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/t1042qds.dts b/arch/powerpc/boot/dts/t=
1042qds.dts
new file mode 100644
index 0000000..42662e1
--- /dev/null
+++ b/arch/powerpc/boot/dts/t1042qds.dts
@@ -0,0 +1,201 @@
+/*
+ * T1042QDS Device Tree Source
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions ar=
e met:
+ *     * Redistributions of source code must retain the above copyright
+ *	 notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyrig=
ht
+ *	 notice, this list of conditions and the following disclaimer in the
+ *	 documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *	 names of its contributors may be used to endorse or promote products
+ *	 derived from this software without specific prior written permission=
.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of th=
e
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMP=
LIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AR=
E
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR A=
NY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DA=
MAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SE=
RVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUS=
ED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR=
 TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE=
 OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "fsl/t104xsi-pre.dtsi"
+
+/ {
+	model =3D "fsl,T1042QDS";
+	compatible =3D "fsl,T1042QDS";
+	#address-cells =3D <2>;
+	#size-cells =3D <2>;
+	interrupt-parent =3D <&mpic>;
+
+	aliases {
+		 /* TODO */
+		};
+
+	ifc: localbus@ffe124000 {
+		reg =3D <0xf 0xfe124000 0 0x2000>;
+		ranges =3D <0 0 0xf 0xe8000000 0x08000000
+			  2 0 0xf 0xff800000 0x00010000
+			  3 0 0xf 0xffdf0000 0x00008000>;
+
+		nor@0,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "cfi-flash";
+			reg =3D <0x0 0x0 0x8000000>;
+
+			bank-width =3D <2>;
+			device-width =3D <1>;
+		};
+
+		nand@2,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "fsl,ifc-nand";
+			reg =3D <0x2 0x0 0x10000>;
+
+			partition@0 {
+				/* This location must not be altered  */
+				/* 1MB for u-boot Bootloader Image */
+				reg =3D <0x0 0x00100000>;
+				label =3D "NAND U-Boot Image";
+				read-only;
+			};
+
+			partition@100000 {
+				/* 1MB for DTB Image */
+				reg =3D <0x00100000 0x00100000>;
+				label =3D "NAND DTB Image";
+			};
+
+			partition@200000 {
+				/* 10MB for Linux Kernel Image */
+				reg =3D <0x00200000 0x00A00000>;
+				label =3D "NAND Linux Kernel Image";
+			};
+
+			partition@C00000 {
+				/* 500MB for Root file System Image */
+				reg =3D <0x00c00000 0x1F400000>;
+				label =3D "NAND RFS Image";
+			};
+		};
+
+		board-control@3,0 {
+			#address-cells =3D <1>;
+			#size-cells =3D <1>;
+			compatible =3D "fsl,tetra-fpga", "fsl,fpga-qixis";
+			reg =3D <3 0 0x300>;
+		};
+	};
+
+	memory {
+		device_type =3D "memory";
+	};
+
+	dcsr: dcsr@f00000000 {
+		ranges =3D <0x00000000 0xf 0x00000000 0x01072000>;
+	};
+
+	soc: soc@ffe000000 {
+		ranges =3D <0x00000000 0xf 0xfe000000 0x1000000>;
+		reg =3D <0xf 0xfe000000 0 0x00001000>;
+		spi@110000 {
+			flash@0 {
+				#address-cells =3D <1>;
+				#size-cells =3D <1>;
+				compatible =3D "micron,n25q512a";
+				reg =3D <0>;
+				spi-max-frequency =3D <10000000>; /* input clock */
+			};
+		};
+
+		i2c@118000 {
+                        pca9547@77 {
+                                compatible =3D "philips,pca9547";
+                                reg =3D <0x77>;
+                        };
+                       rtc@68 {
+                                compatible =3D "dallas,ds3232";
+                                reg =3D <0x68>;
+                                interrupts =3D <0x1 0x1 0 0>;
+                        };
+		};
+
+	};
+
+	pci0: pcie@ffe240000 {
+		reg =3D <0xf 0xfe240000 0 0x10000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci1: pcie@ffe250000 {
+		reg =3D <0xf 0xfe250000 0 0x10000>;
+		ranges =3D <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x10000000
+			  0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci2: pcie@ffe260000 {
+		reg =3D <0xf 0xfe260000 0 0x1000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci3: pcie@ffe270000 {
+		reg =3D <0xf 0xfe270000 0 0x10000>;
+		ranges =3D <0x02000000 0 0xe0000000 0xc 0x60000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
+		pcie@0 {
+			ranges =3D <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+};
+
+/include/ "fsl/t1042si-post.dtsi"
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms=
/85xx/Kconfig
index efdd37c..503c211 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -289,6 +289,26 @@ config P5040_DS
 	help
 	  This option enables support for the P5040 DS board
=20
+config T104x_QDS
+	bool "Freescale T104x QDS"
+	select DEFAULT_UIMAGE
+	select E500
+	select PPC_E500MC
+	select PHYS_64BIT
+	select SWIOTLB
+	select ARCH_REQUIRE_GPIOLIB
+	select GENERIC_GPIO
+	select HAS_RAPIDIO
+	select PPC_EPAPR_HV_PIC
+	select HAS_FSL_QBMAN
+	select MDIO_BUS_MUX if FSL_DPAA_ETH
+	select MDIO_BUS_MUX_MMIOREG if FSL_DPAA_ETH
+	help
+	  This option enables support for the T04x QDS board
+	  The T104x application development system T104x QDS is a complete
+	  debugging environment intended for engineers developing
+	  applications for the T1040/T1042.
+
 config PPC_QEMU_E500
 	bool "QEMU generic e500 platform"
 	select DEFAULT_UIMAGE
diff --git a/arch/powerpc/platforms/85xx/Makefile b/arch/powerpc/platform=
s/85xx/Makefile
index 2eab37e..9c25a38 100644
--- a/arch/powerpc/platforms/85xx/Makefile
+++ b/arch/powerpc/platforms/85xx/Makefile
@@ -22,6 +22,7 @@ obj-$(CONFIG_P3041_DS)    +=3D p3041_ds.o corenet_ds.o
 obj-$(CONFIG_P4080_DS)    +=3D p4080_ds.o corenet_ds.o
 obj-$(CONFIG_P5020_DS)    +=3D p5020_ds.o corenet_ds.o
 obj-$(CONFIG_P5040_DS)    +=3D p5040_ds.o corenet_ds.o
+obj-$(CONFIG_T104x_QDS)   +=3D t104x_qds.o corenet_ds.o
 obj-$(CONFIG_T4240_QDS)   +=3D t4240_qds.o corenet_ds.o
 obj-$(CONFIG_B4_QDS)	  +=3D b4_qds.o corenet_ds.o
 obj-$(CONFIG_STX_GP3)	  +=3D stx_gp3.o
diff --git a/arch/powerpc/platforms/85xx/t104x_qds.c b/arch/powerpc/platf=
orms/85xx/t104x_qds.c
new file mode 100644
index 0000000..d28da14
--- /dev/null
+++ b/arch/powerpc/platforms/85xx/t104x_qds.c
@@ -0,0 +1,102 @@
+/*
+ * T104x QDS Setup
+ * Should apply for QDS platform of T1040 and it's personalities.
+ * viz T1040/T1042
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * This program is free software; you can redistribute	it and/or modify =
it
+ * under  the terms of	the GNU General	 Public License as published by t=
he
+ * Free Software Foundation;  either version 2 of the  License, or (at y=
our
+ * option) any later version.
+ */
+
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/kdev_t.h>
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/phy.h>
+
+#include <asm/time.h>
+#include <asm/machdep.h>
+#include <asm/pci-bridge.h>
+#include <mm/mmu_decl.h>
+#include <asm/prom.h>
+#include <asm/udbg.h>
+#include <asm/mpic.h>
+
+#include <linux/of_platform.h>
+#include <sysdev/fsl_soc.h>
+#include <sysdev/fsl_pci.h>
+#include <asm/ehv_pic.h>
+
+#include "corenet_ds.h"
+
+/*
+ * Called very early, device-tree isn't unflattened
+ */
+static int __init t104x_qds_probe(void)
+{
+	unsigned long root =3D of_get_flat_dt_root();
+#ifdef CONFIG_SMP
+	extern struct smp_ops_t smp_85xx_ops;
+#endif
+
+	if (of_flat_dt_is_compatible(root, "fsl,T1040QDS") ||
+		of_flat_dt_is_compatible(root, "fsl,T1042QDS"))
+
+		return 1;
+
+	/* Check if we're running under the Freescale hypervisor */
+	if (of_flat_dt_is_compatible(root, "fsl,T1040QDS-hv") ||
+		of_flat_dt_is_compatible(root, "fsl,T1042QDS-hv")) {
+		ppc_md.init_IRQ =3D ehv_pic_init;
+		ppc_md.get_irq =3D ehv_pic_get_irq;
+		ppc_md.restart =3D fsl_hv_restart;
+		ppc_md.power_off =3D fsl_hv_halt;
+		ppc_md.halt =3D fsl_hv_halt;
+#ifdef CONFIG_SMP
+		/*
+		 * Disable the timebase sync operations because we can't write
+		 * to the timebase registers under the hypervisor.
+		  */
+		smp_85xx_ops.give_timebase =3D NULL;
+		smp_85xx_ops.take_timebase =3D NULL;
+#endif
+
+		return 1;
+	}
+
+	return 0;
+}
+
+define_machine(t104x_qds) {
+	.name			=3D "T104x QDS",
+	.probe			=3D t104x_qds_probe,
+	.setup_arch		=3D corenet_ds_setup_arch,
+	.init_IRQ		=3D corenet_ds_pic_init,
+#ifdef CONFIG_PCI
+	.pcibios_fixup_bus	=3D fsl_pcibios_fixup_bus,
+#endif
+/* coreint doesn't play nice with lazy EE, use legacy mpic for now */
+#ifdef CONFIG_PPC64
+	.get_irq		=3D mpic_get_irq,
+#else
+	.get_irq		=3D mpic_get_coreint_irq,
+#endif
+	.restart		=3D fsl_rstcr_restart,
+	.calibrate_decr		=3D generic_calibrate_decr,
+	.progress		=3D udbg_progress,
+#ifdef CONFIG_PPC64
+	.power_save		=3D book3e_idle,
+#else
+	.power_save		=3D e500_idle,
+#endif
+};
+
+machine_arch_initcall(t104x_qds, corenet_ds_publish_devices);
+
+#ifdef CONFIG_SWIOTLB
+machine_arch_initcall(t104x_qds, swiotlb_setup_bus_notifier);
+#endif
--=20
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support
  2013-09-11  6:58 [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support Prabhakar Kushwaha
@ 2013-09-11 23:41 ` Scott Wood
  2013-09-13  7:35   ` Kushwaha Prabhakar-B32579
  0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2013-09-11 23:41 UTC (permalink / raw)
  To: Prabhakar Kushwaha; +Cc: Priyanka Jain, linuxppc-dev, Poonam Aggrwal

On Wed, 2013-09-11 at 12:28 +0530, Prabhakar Kushwaha wrote:
>  Add support for T104x board in board file t104x_qds.c, It is common fo=
r
>  both T1040 and T1042 as they share same QDS board.
>=20
>  T1040QDS board Overview
>  -----------------------
>  - SERDES Connections, 8 lanes supporting:
>       =E2=80=94 PCI Express: supporting Gen 1 and Gen 2;
>       =E2=80=94 SGMII
>       =E2=80=94 QSGMII
>       =E2=80=94 SATA 2.0
>       =E2=80=94 Aurora debug with dedicated connectors (T1040 only)
>  - DDR Controller
>      - Supports rates of up to 1600 MHz data-rate
>      - Supports one DDR3LP UDIMM/RDIMMs, of single-, dual- or quad-rank=
 types.
>  -IFC/Local Bus
>      - NAND flash: 8-bit, async, up to 2GB.
>      - NOR: 8-bit or 16-bit, non-multiplexed, up to 512MB
>      - GASIC: Simple (minimal) target within Qixis FPGA
>      - PromJET rapid memory download support
>  - Ethernet
>      - Two on-board RGMII 10/100/1G ethernet ports.
>      - PHY #0 remains powered up during deep-sleep (T1040 only)
>  - QIXIS System Logic FPGA
>  - Clocks
>      - System and DDR clock (SYSCLK, =E2=80=9CDDRCLK=E2=80=9D)
>      - SERDES clocks
>  - Power Supplies
>  - Video
>      - DIU supports video at up to 1280x1024x32bpp
>  - USB
>      - Supports two USB 2.0 ports with integrated PHYs
>      =E2=80=94 Two type A ports with 5V@1.5A per port.
>      =E2=80=94 Second port can be converted to OTG mini-AB
>  - SDHC
>      - SDHC port connects directly to an adapter card slot, featuring:
>      - Supporting SD slots for: SD, SDHC (1x, 4x, 8x) and/or MMC
>      =E2=80=94 Supporting eMMC memory devices
>  - SPI
>     -  On-board support of 3 different devices and sizes
>  - Other IO
>     - Two Serial ports
>     - ProfiBus port
>     - Four I2C ports
>=20
>  Add T104xQDS support in Kconfig and Makefile. Also create device tree.
>=20
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linu=
x.git
>=20
> TODO: Add noded for ethernet and board stuff

"board stuff"?

Isn't "board stuff" the whole point of this patch? :-)

>  arch/powerpc/boot/dts/t1040qds.dts      |  201 +++++++++++++++++++++++=
++++++++
>  arch/powerpc/boot/dts/t1042qds.dts      |  201 +++++++++++++++++++++++=
++++++++
>  arch/powerpc/platforms/85xx/Kconfig     |   20 +++
>  arch/powerpc/platforms/85xx/Makefile    |    1 +
>  arch/powerpc/platforms/85xx/t104x_qds.c |  102 ++++++++++++++++
>  5 files changed, 525 insertions(+)
>  create mode 100644 arch/powerpc/boot/dts/t1040qds.dts
>  create mode 100644 arch/powerpc/boot/dts/t1042qds.dts
>  create mode 100644 arch/powerpc/platforms/85xx/t104x_qds.c
>=20
> diff --git a/arch/powerpc/boot/dts/t1040qds.dts b/arch/powerpc/boot/dts=
/t1040qds.dts
> new file mode 100644
> index 0000000..cea5632
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/t1040qds.dts
> @@ -0,0 +1,201 @@
> +/*
> + * T1040QDS Device Tree Source
> + *
> + * Copyright 2013 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions =
are met:
> + *     * Redistributions of source code must retain the above copyrigh=
t
> + *	 notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above copyr=
ight
> + *	 notice, this list of conditions and the following disclaimer in th=
e
> + *	 documentation and/or other materials provided with the distributio=
n.
> + *     * Neither the name of Freescale Semiconductor nor the
> + *	 names of its contributors may be used to endorse or promote produc=
ts
> + *	 derived from this software without specific prior written permissi=
on.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of =
the
> + * GNU General Public License ("GPL") as published by the Free Softwar=
e
> + * Foundation, either version 2 of that License or (at your option) an=
y
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND AN=
Y
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE I=
MPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE =
ARE
> + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR=
 ANY
> + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL =
DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR =
SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CA=
USED AND
> + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, =
OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE U=
SE OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/include/ "fsl/t104xsi-pre.dtsi"
> +
> +/ {
> +	model =3D "fsl,T1040QDS";
> +	compatible =3D "fsl,T1040QDS";
> +	#address-cells =3D <2>;
> +	#size-cells =3D <2>;
> +	interrupt-parent =3D <&mpic>;
> +
> +	aliases {
> +		 /* TODO */
> +		};

TODO?  Did you mean this patch as an RFC?

Also, whitespace.

> +		i2c@118000 {
> +                        pca9547@77 {
> +                                compatible =3D "philips,pca9547";
> +                                reg =3D <0x77>;
> +                        };
> +                       rtc@68 {
> +                                compatible =3D "dallas,ds3232";
> +                                reg =3D <0x68>;
> +                                interrupts =3D <0x1 0x1 0 0>;
> +                        };
> +		};
> +
> +	};

Whitespace

> +
> +	pci0: pcie@ffe240000 {
> +		reg =3D <0xf 0xfe240000 0 0x10000>;
> +		ranges =3D <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x10000000
> +			  0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
> +		pcie@0 {
> +			ranges =3D <0x02000000 0 0xe0000000
> +				  0x02000000 0 0xe0000000
> +				  0 0x10000000
> +
> +				  0x01000000 0 0x00000000
> +				  0x01000000 0 0x00000000
> +				  0 0x00010000>;
> +		};
> +	};
> +
> +	pci1: pcie@ffe250000 {
> +		reg =3D <0xf 0xfe250000 0 0x10000>;
> +		ranges =3D <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x10000000
> +			  0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
> +		pcie@0 {
> +			ranges =3D <0x02000000 0 0xe0000000
> +				  0x02000000 0 0xe0000000
> +				  0 0x10000000
> +
> +				  0x01000000 0 0x00000000
> +				  0x01000000 0 0x00000000
> +				  0 0x00010000>;
> +		};
> +	};
> +
> +	pci2: pcie@ffe260000 {
> +		reg =3D <0xf 0xfe260000 0 0x1000>;
> +		ranges =3D <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x10000000
> +			  0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
> +		pcie@0 {
> +			ranges =3D <0x02000000 0 0xe0000000
> +				  0x02000000 0 0xe0000000
> +				  0 0x10000000
> +
> +				  0x01000000 0 0x00000000
> +				  0x01000000 0 0x00000000
> +				  0 0x00010000>;
> +		};
> +	};
> +
> +	pci3: pcie@ffe270000 {
> +		reg =3D <0xf 0xfe270000 0 0x10000>;
> +		ranges =3D <0x02000000 0 0xe0000000 0xc 0x60000000 0 0x10000000
> +			  0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
> +		pcie@0 {
> +			ranges =3D <0x02000000 0 0xe0000000
> +				  0x02000000 0 0xe0000000
> +				  0 0x10000000
> +
> +				  0x01000000 0 0x00000000
> +				  0x01000000 0 0x00000000
> +				  0 0x00010000>;
> +		};
> +	};
> +};

Maybe some of this stuff could be put in a common dtsi between t1040 and
t1042?

Ideally for t1042 you'd just take the entire t1040 tree as an include,
and add the switch

> diff --git a/arch/powerpc/platforms/85xx/t104x_qds.c b/arch/powerpc/pla=
tforms/85xx/t104x_qds.c
> new file mode 100644
> index 0000000..d28da14
> --- /dev/null
> +++ b/arch/powerpc/platforms/85xx/t104x_qds.c
> @@ -0,0 +1,102 @@
> +/*
> + * T104x QDS Setup
> + * Should apply for QDS platform of T1040 and it's personalities.
> + * viz T1040/T1042
> + *
> + * Copyright 2013 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute	it and/or modif=
y it
> + * under  the terms of	the GNU General	 Public License as published by=
 the
> + * Free Software Foundation;  either version 2 of the  License, or (at=
 your
> + * option) any later version.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/pci.h>
> +#include <linux/kdev_t.h>
> +#include <linux/delay.h>
> +#include <linux/interrupt.h>
> +#include <linux/phy.h>
> +
> +#include <asm/time.h>
> +#include <asm/machdep.h>
> +#include <asm/pci-bridge.h>
> +#include <mm/mmu_decl.h>
> +#include <asm/prom.h>
> +#include <asm/udbg.h>
> +#include <asm/mpic.h>
> +
> +#include <linux/of_platform.h>
> +#include <sysdev/fsl_soc.h>
> +#include <sysdev/fsl_pci.h>
> +#include <asm/ehv_pic.h>
> +
> +#include "corenet_ds.h"

You don't need all of these includes.

> +define_machine(t104x_qds) {
> +	.name			=3D "T104x QDS",
> +	.probe			=3D t104x_qds_probe,

Should we have two machine descriptions, so that the proper chip name
shows up (e.g. in /proc/cpuinfo)?

> +/* coreint doesn't play nice with lazy EE, use legacy mpic for now */
> +#ifdef CONFIG_PPC64
> +	.get_irq		=3D mpic_get_irq,
> +#else
> +	.get_irq		=3D mpic_get_coreint_irq,
> +#endif

This isn't true any more.  When submitting code that was copied from
elsewhere, please check whether there were any updates in the code that
you copied from (unless you copied from b4qds, which the update missed
-- I just sent a patch to fix that).

-Scott

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support
  2013-09-11 23:41 ` Scott Wood
@ 2013-09-13  7:35   ` Kushwaha Prabhakar-B32579
  2013-09-16 20:44     ` Scott Wood
  0 siblings, 1 reply; 4+ messages in thread
From: Kushwaha Prabhakar-B32579 @ 2013-09-13  7:35 UTC (permalink / raw)
  To: Wood Scott-B07421
  Cc: Jain Priyanka-B32167, Aggrwal Poonam-B10812,
	linuxppc-dev@lists.ozlabs.org

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAxMiwgMjAxMyA1OjExIEFNDQo+IFRvOiBL
dXNod2FoYSBQcmFiaGFrYXItQjMyNTc5DQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz
Lm9yZzsgZ2FsYWtAa2VybmVsLmNyYXNoaW5nLm9yZzsgSmFpbg0KPiBQcml5YW5rYS1CMzIxNjc7
IEFnZ3J3YWwgUG9vbmFtLUIxMDgxMg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvMl0gcG93ZXJw
Yy9mc2wtYm9va2U6IEFkZCBpbml0aWFsIFQxMDR4X1FEUyBib2FyZA0KPiBzdXBwb3J0DQo+IA0K
PiBPbiBXZWQsIDIwMTMtMDktMTEgYXQgMTI6MjggKzA1MzAsIFByYWJoYWthciBLdXNod2FoYSB3
cm90ZToNCj4gPiAgQWRkIHN1cHBvcnQgZm9yIFQxMDR4IGJvYXJkIGluIGJvYXJkIGZpbGUgdDEw
NHhfcWRzLmMsIEl0IGlzIGNvbW1vbg0KPiA+IGZvciAgYm90aCBUMTA0MCBhbmQgVDEwNDIgYXMg
dGhleSBzaGFyZSBzYW1lIFFEUyBib2FyZC4NCj4gPg0KPiA+ICBUMTA0MFFEUyBib2FyZCBPdmVy
dmlldw0KPiA+ICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAtIFNFUkRFUyBDb25uZWN0
aW9ucywgOCBsYW5lcyBzdXBwb3J0aW5nOg0KPiA+ICAgICAgIOKAlCBQQ0kgRXhwcmVzczogc3Vw
cG9ydGluZyBHZW4gMSBhbmQgR2VuIDI7DQo+ID4gICAgICAg4oCUIFNHTUlJDQo+ID4gICAgICAg
4oCUIFFTR01JSQ0KPiA+ICAgICAgIOKAlCBTQVRBIDIuMA0KPiA+ICAgICAgIOKAlCBBdXJvcmEg
ZGVidWcgd2l0aCBkZWRpY2F0ZWQgY29ubmVjdG9ycyAoVDEwNDAgb25seSkNCj4gPiAgLSBERFIg
Q29udHJvbGxlcg0KPiA+ICAgICAgLSBTdXBwb3J0cyByYXRlcyBvZiB1cCB0byAxNjAwIE1IeiBk
YXRhLXJhdGUNCj4gPiAgICAgIC0gU3VwcG9ydHMgb25lIEREUjNMUCBVRElNTS9SRElNTXMsIG9m
IHNpbmdsZS0sIGR1YWwtIG9yIHF1YWQtcmFuaw0KPiB0eXBlcy4NCj4gPiAgLUlGQy9Mb2NhbCBC
dXMNCj4gPiAgICAgIC0gTkFORCBmbGFzaDogOC1iaXQsIGFzeW5jLCB1cCB0byAyR0IuDQo+ID4g
ICAgICAtIE5PUjogOC1iaXQgb3IgMTYtYml0LCBub24tbXVsdGlwbGV4ZWQsIHVwIHRvIDUxMk1C
DQo+ID4gICAgICAtIEdBU0lDOiBTaW1wbGUgKG1pbmltYWwpIHRhcmdldCB3aXRoaW4gUWl4aXMg
RlBHQQ0KPiA+ICAgICAgLSBQcm9tSkVUIHJhcGlkIG1lbW9yeSBkb3dubG9hZCBzdXBwb3J0DQo+
ID4gIC0gRXRoZXJuZXQNCj4gPiAgICAgIC0gVHdvIG9uLWJvYXJkIFJHTUlJIDEwLzEwMC8xRyBl
dGhlcm5ldCBwb3J0cy4NCj4gPiAgICAgIC0gUEhZICMwIHJlbWFpbnMgcG93ZXJlZCB1cCBkdXJp
bmcgZGVlcC1zbGVlcCAoVDEwNDAgb25seSkNCj4gPiAgLSBRSVhJUyBTeXN0ZW0gTG9naWMgRlBH
QQ0KPiA+ICAtIENsb2Nrcw0KPiA+ICAgICAgLSBTeXN0ZW0gYW5kIEREUiBjbG9jayAoU1lTQ0xL
LCDigJxERFJDTEvigJ0pDQo+ID4gICAgICAtIFNFUkRFUyBjbG9ja3MNCj4gPiAgLSBQb3dlciBT
dXBwbGllcw0KPiA+ICAtIFZpZGVvDQo+ID4gICAgICAtIERJVSBzdXBwb3J0cyB2aWRlbyBhdCB1
cCB0byAxMjgweDEwMjR4MzJicHANCj4gPiAgLSBVU0INCj4gPiAgICAgIC0gU3VwcG9ydHMgdHdv
IFVTQiAyLjAgcG9ydHMgd2l0aCBpbnRlZ3JhdGVkIFBIWXMNCj4gPiAgICAgIOKAlCBUd28gdHlw
ZSBBIHBvcnRzIHdpdGggNVZAMS41QSBwZXIgcG9ydC4NCj4gPiAgICAgIOKAlCBTZWNvbmQgcG9y
dCBjYW4gYmUgY29udmVydGVkIHRvIE9URyBtaW5pLUFCDQo+ID4gIC0gU0RIQw0KPiA+ICAgICAg
LSBTREhDIHBvcnQgY29ubmVjdHMgZGlyZWN0bHkgdG8gYW4gYWRhcHRlciBjYXJkIHNsb3QsIGZl
YXR1cmluZzoNCj4gPiAgICAgIC0gU3VwcG9ydGluZyBTRCBzbG90cyBmb3I6IFNELCBTREhDICgx
eCwgNHgsIDh4KSBhbmQvb3IgTU1DDQo+ID4gICAgICDigJQgU3VwcG9ydGluZyBlTU1DIG1lbW9y
eSBkZXZpY2VzDQo+ID4gIC0gU1BJDQo+ID4gICAgIC0gIE9uLWJvYXJkIHN1cHBvcnQgb2YgMyBk
aWZmZXJlbnQgZGV2aWNlcyBhbmQgc2l6ZXMNCj4gPiAgLSBPdGhlciBJTw0KPiA+ICAgICAtIFR3
byBTZXJpYWwgcG9ydHMNCj4gPiAgICAgLSBQcm9maUJ1cyBwb3J0DQo+ID4gICAgIC0gRm91ciBJ
MkMgcG9ydHMNCj4gPg0KPiA+ICBBZGQgVDEwNHhRRFMgc3VwcG9ydCBpbiBLY29uZmlnIGFuZCBN
YWtlZmlsZS4gQWxzbyBjcmVhdGUgZGV2aWNlIHRyZWUuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5
OiBQcml5YW5rYSBKYWluIDxQcml5YW5rYS5KYWluQGZyZWVzY2FsZS5jb20+DQo+ID4gU2lnbmVk
LW9mZi1ieTogUG9vbmFtIEFnZ3J3YWwgPHBvb25hbS5hZ2dyd2FsQGZyZWVzY2FsZS5jb20+DQo+
ID4gU2lnbmVkLW9mZi1ieTogUHJhYmhha2FyIEt1c2h3YWhhIDxwcmFiaGFrYXJAZnJlZXNjYWxl
LmNvbT4NCj4gPiAtLS0NCj4gPiBCYXNlZCB1cG9uDQo+ID4gZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcv
cHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3Njb3R0d29vZC9saW51eC5naXQNCj4gPg0KPiA+IFRP
RE86IEFkZCBub2RlZCBmb3IgZXRoZXJuZXQgYW5kIGJvYXJkIHN0dWZmDQo+IA0KPiAiYm9hcmQg
c3R1ZmYiPw0KPiANCj4gSXNuJ3QgImJvYXJkIHN0dWZmIiB0aGUgd2hvbGUgcG9pbnQgb2YgdGhp
cyBwYXRjaD8gOi0pDQo+IA0KDQo6KQ0KDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy90MTA0
MHFkcy5kdHMgICAgICB8ICAyMDENCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0K
PiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDEwNDJxZHMuZHRzICAgICAgfCAgMjAxDQo+ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgYXJjaC9wb3dlcnBjL3BsYXRmb3Jt
cy84NXh4L0tjb25maWcgICAgIHwgICAyMCArKysNCj4gPiAgYXJjaC9wb3dlcnBjL3BsYXRmb3Jt
cy84NXh4L01ha2VmaWxlICAgIHwgICAgMSArDQo+ID4gIGFyY2gvcG93ZXJwYy9wbGF0Zm9ybXMv
ODV4eC90MTA0eF9xZHMuYyB8ICAxMDIgKysrKysrKysrKysrKysrKw0KPiA+ICA1IGZpbGVzIGNo
YW5nZWQsIDUyNSBpbnNlcnRpb25zKCspDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL3Bv
d2VycGMvYm9vdC9kdHMvdDEwNDBxZHMuZHRzDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNo
L3Bvd2VycGMvYm9vdC9kdHMvdDEwNDJxZHMuZHRzDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBh
cmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgvdDEwNHhfcWRzLmMNCj4gPg0KPiA+IGRpZmYgLS1n
aXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDEwNDBxZHMuZHRzDQo+ID4gYi9hcmNoL3Bvd2Vy
cGMvYm9vdC9kdHMvdDEwNDBxZHMuZHRzDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBp
bmRleCAwMDAwMDAwLi5jZWE1NjMyDQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL2FyY2gv
cG93ZXJwYy9ib290L2R0cy90MTA0MHFkcy5kdHMNCj4gPiBAQCAtMCwwICsxLDIwMSBAQA0KPiA+
ICsvKg0KPiA+ICsgKiBUMTA0MFFEUyBEZXZpY2UgVHJlZSBTb3VyY2UNCj4gPiArICoNCj4gPiAr
ICogQ29weXJpZ2h0IDIwMTMgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgSW5jLg0KPiA+ICsgKg0K
PiA+ICsgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z
LCB3aXRoIG9yIHdpdGhvdXQNCj4gPiArICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy
b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zDQo+IGFyZSBtZXQ6DQo+ID4gKyAq
ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv
dmUNCj4gY29weXJpZ2h0DQo+ID4gKyAqCSBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z
IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuDQo+ID4gKyAqICAgICAqIFJlZGlzdHJpYnV0
aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUNCj4gY29weXJpZ2h0
DQo+ID4gKyAqCSBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93
aW5nIGRpc2NsYWltZXIgaW4NCj4gdGhlDQo+ID4gKyAqCSBkb2N1bWVudGF0aW9uIGFuZC9vciBv
dGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUNCj4gZGlzdHJpYnV0aW9uLg0KPiA+ICsg
KiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEZyZWVzY2FsZSBTZW1pY29uZHVjdG9yIG5vciB0
aGUNCj4gPiArICoJIG5hbWVzIG9mIGl0cyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5k
b3JzZSBvciBwcm9tb3RlDQo+IHByb2R1Y3RzDQo+ID4gKyAqCSBkZXJpdmVkIGZyb20gdGhpcyBz
b2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4NCj4gcGVybWlzc2lvbi4NCj4g
PiArICoNCj4gPiArICoNCj4gPiArICogQUxURVJOQVRJVkVMWSwgdGhpcyBzb2Z0d2FyZSBtYXkg
YmUgZGlzdHJpYnV0ZWQgdW5kZXIgdGhlIHRlcm1zIG9mDQo+ID4gK3RoZQ0KPiA+ICsgKiBHTlUg
R2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoIkdQTCIpIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZQ0K
PiA+ICtTb2Z0d2FyZQ0KPiA+ICsgKiBGb3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAyIG9mIHRo
YXQgTGljZW5zZSBvciAoYXQgeW91ciBvcHRpb24pDQo+ID4gK2FueQ0KPiA+ICsgKiBsYXRlciB2
ZXJzaW9uLg0KPiA+ICsgKg0KPiA+ICsgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEZy
ZWVzY2FsZSBTZW1pY29uZHVjdG9yICJBUyBJUyIgQU5EDQo+ID4gK0FOWQ0KPiA+ICsgKiBFWFBS
RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s
IFRIRQ0KPiA+ICtJTVBMSUVEDQo+ID4gKyAqIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZ
IEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRQ0KPiA+ICtBUkUNCj4gPiArICog
RElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgQkUg
TElBQkxFDQo+ID4gK0ZPUiBBTlkNCj4gPiArICogRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRB
TCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMDQo+ID4gK0RBTUFHRVMNCj4g
PiArICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJT
VElUVVRFIEdPT0RTIE9SDQo+ID4gK1NFUlZJQ0VTOw0KPiA+ICsgKiBMT1NTIE9GIFVTRSwgREFU
QSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSDQo+ID4gK0NB
VVNFRCBBTkQNCj4gPiArICogT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g
Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksDQo+ID4gK09SIFRPUlQNCj4gPiArICogKElOQ0xV
RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU
SEUNCj4gPiArVVNFIE9GIFRISVMNCj4gPiArICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP
RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuDQo+ID4gKyAqLw0KPiA+ICsNCj4gPiAr
L2luY2x1ZGUvICJmc2wvdDEwNHhzaS1wcmUuZHRzaSINCj4gPiArDQo+ID4gKy8gew0KPiA+ICsJ
bW9kZWwgPSAiZnNsLFQxMDQwUURTIjsNCj4gPiArCWNvbXBhdGlibGUgPSAiZnNsLFQxMDQwUURT
IjsNCj4gPiArCSNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KPiA+ICsJI3NpemUtY2VsbHMgPSA8Mj47
DQo+ID4gKwlpbnRlcnJ1cHQtcGFyZW50ID0gPCZtcGljPjsNCj4gPiArDQo+ID4gKwlhbGlhc2Vz
IHsNCj4gPiArCQkgLyogVE9ETyAqLw0KPiA+ICsJCX07DQo+IA0KPiBUT0RPPyAgRGlkIHlvdSBt
ZWFuIHRoaXMgcGF0Y2ggYXMgYW4gUkZDPw0KPiANCg0KDQphY3R1YWxseSwgdGhpcyBwYXRjaCBp
cyBub3QgYWRkaW5nIGluIGRwYWEgcmVsYXRlZCBub2RlKGZtYW4sYm1hbiBldGMpLg0KSSBhbSBr
ZWVwaW5nIHBsYWNlIGhvbGRlciBmb3IgYWxpYXMgb2YgRXRoZXJuZXQgbm9kZXMuIA0KDQo+IEFs
c28sIHdoaXRlc3BhY2UuDQo+IA0KDQpkb2VzIHdoaXRlc3BhY2UgaXMgbm90IGNhcHR1cmVkIGlu
IGNoZWNrcGF0Y2g/DQoNCj4gPiArCQlpMmNAMTE4MDAwIHsNCj4gPiArICAgICAgICAgICAgICAg
ICAgICAgICAgcGNhOTU0N0A3NyB7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgY29tcGF0aWJsZSA9ICJwaGlsaXBzLHBjYTk1NDciOw0KPiA+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHJlZyA9IDwweDc3PjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAg
ICAgfTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBydGNANjggew0KPiA+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZGFsbGFzLGRzMzIzMiI7DQo+
ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4Njg+Ow0KPiA+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8MHgxIDB4MSAwIDA+
Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+ICsJCX07DQo+ID4gKw0KPiA+
ICsJfTsNCj4gDQo+IFdoaXRlc3BhY2UNCj4gDQo+ID4gKw0KPiA+ICsJcGNpMDogcGNpZUBmZmUy
NDAwMDAgew0KPiA+ICsJCXJlZyA9IDwweGYgMHhmZTI0MDAwMCAwIDB4MTAwMDA+Ow0KPiA+ICsJ
CXJhbmdlcyA9IDwweDAyMDAwMDAwIDAgMHhlMDAwMDAwMCAweGMgMHgwMDAwMDAwMCAweDANCj4g
MHgxMDAwMDAwMA0KPiA+ICsJCQkgIDB4MDEwMDAwMDAgMCAweDAwMDAwMDAwIDB4ZiAweGY4MDAw
MDAwIDB4MA0KPiAweDAwMDEwMDAwPjsNCj4gPiArCQlwY2llQDAgew0KPiA+ICsJCQlyYW5nZXMg
PSA8MHgwMjAwMDAwMCAwIDB4ZTAwMDAwMDANCj4gPiArCQkJCSAgMHgwMjAwMDAwMCAwIDB4ZTAw
MDAwMDANCj4gPiArCQkJCSAgMCAweDEwMDAwMDAwDQo+ID4gKw0KPiA+ICsJCQkJICAweDAxMDAw
MDAwIDAgMHgwMDAwMDAwMA0KPiA+ICsJCQkJICAweDAxMDAwMDAwIDAgMHgwMDAwMDAwMA0KPiA+
ICsJCQkJICAwIDB4MDAwMTAwMDA+Ow0KPiA+ICsJCX07DQo+ID4gKwl9Ow0KPiA+ICsNCj4gPiAr
CXBjaTE6IHBjaWVAZmZlMjUwMDAwIHsNCj4gPiArCQlyZWcgPSA8MHhmIDB4ZmUyNTAwMDAgMCAw
eDEwMDAwPjsNCj4gPiArCQlyYW5nZXMgPSA8MHgwMjAwMDAwMCAweDAgMHhlMDAwMDAwMCAweGMg
MHgyMDAwMDAwMCAweDANCj4gMHgxMDAwMDAwMA0KPiA+ICsJCQkgIDB4MDEwMDAwMDAgMHgwIDB4
MDAwMDAwMDAgMHhmIDB4ZjgwMTAwMDAgMHgwDQo+IDB4MDAwMTAwMDA+Ow0KPiA+ICsJCXBjaWVA
MCB7DQo+ID4gKwkJCXJhbmdlcyA9IDwweDAyMDAwMDAwIDAgMHhlMDAwMDAwMA0KPiA+ICsJCQkJ
ICAweDAyMDAwMDAwIDAgMHhlMDAwMDAwMA0KPiA+ICsJCQkJICAwIDB4MTAwMDAwMDANCj4gPiAr
DQo+ID4gKwkJCQkgIDB4MDEwMDAwMDAgMCAweDAwMDAwMDAwDQo+ID4gKwkJCQkgIDB4MDEwMDAw
MDAgMCAweDAwMDAwMDAwDQo+ID4gKwkJCQkgIDAgMHgwMDAxMDAwMD47DQo+ID4gKwkJfTsNCj4g
PiArCX07DQo+ID4gKw0KPiA+ICsJcGNpMjogcGNpZUBmZmUyNjAwMDAgew0KPiA+ICsJCXJlZyA9
IDwweGYgMHhmZTI2MDAwMCAwIDB4MTAwMD47DQo+ID4gKwkJcmFuZ2VzID0gPDB4MDIwMDAwMDAg
MCAweGUwMDAwMDAwIDB4YyAweDQwMDAwMDAwIDAgMHgxMDAwMDAwMA0KPiA+ICsJCQkgIDB4MDEw
MDAwMDAgMCAweDAwMDAwMDAwIDB4ZiAweGY4MDIwMDAwIDAgMHgwMDAxMDAwMD47DQo+ID4gKwkJ
cGNpZUAwIHsNCj4gPiArCQkJcmFuZ2VzID0gPDB4MDIwMDAwMDAgMCAweGUwMDAwMDAwDQo+ID4g
KwkJCQkgIDB4MDIwMDAwMDAgMCAweGUwMDAwMDAwDQo+ID4gKwkJCQkgIDAgMHgxMDAwMDAwMA0K
PiA+ICsNCj4gPiArCQkJCSAgMHgwMTAwMDAwMCAwIDB4MDAwMDAwMDANCj4gPiArCQkJCSAgMHgw
MTAwMDAwMCAwIDB4MDAwMDAwMDANCj4gPiArCQkJCSAgMCAweDAwMDEwMDAwPjsNCj4gPiArCQl9
Ow0KPiA+ICsJfTsNCj4gPiArDQo+ID4gKwlwY2kzOiBwY2llQGZmZTI3MDAwMCB7DQo+ID4gKwkJ
cmVnID0gPDB4ZiAweGZlMjcwMDAwIDAgMHgxMDAwMD47DQo+ID4gKwkJcmFuZ2VzID0gPDB4MDIw
MDAwMDAgMCAweGUwMDAwMDAwIDB4YyAweDYwMDAwMDAwIDAgMHgxMDAwMDAwMA0KPiA+ICsJCQkg
IDB4MDEwMDAwMDAgMCAweDAwMDAwMDAwIDB4ZiAweGY4MDMwMDAwIDAgMHgwMDAxMDAwMD47DQo+
ID4gKwkJcGNpZUAwIHsNCj4gPiArCQkJcmFuZ2VzID0gPDB4MDIwMDAwMDAgMCAweGUwMDAwMDAw
DQo+ID4gKwkJCQkgIDB4MDIwMDAwMDAgMCAweGUwMDAwMDAwDQo+ID4gKwkJCQkgIDAgMHgxMDAw
MDAwMA0KPiA+ICsNCj4gPiArCQkJCSAgMHgwMTAwMDAwMCAwIDB4MDAwMDAwMDANCj4gPiArCQkJ
CSAgMHgwMTAwMDAwMCAwIDB4MDAwMDAwMDANCj4gPiArCQkJCSAgMCAweDAwMDEwMDAwPjsNCj4g
PiArCQl9Ow0KPiA+ICsJfTsNCj4gPiArfTsNCj4gDQo+IE1heWJlIHNvbWUgb2YgdGhpcyBzdHVm
ZiBjb3VsZCBiZSBwdXQgaW4gYSBjb21tb24gZHRzaSBiZXR3ZWVuIHQxMDQwIGFuZA0KPiB0MTA0
Mj8NCj4gDQo+IElkZWFsbHkgZm9yIHQxMDQyIHlvdSdkIGp1c3QgdGFrZSB0aGUgZW50aXJlIHQx
MDQwIHRyZWUgYXMgYW4gaW5jbHVkZSwNCj4gYW5kIGFkZCB0aGUgc3dpdGNoDQo+IA0KDQptZWFu
cywgSSBqdXN0IGNyZWF0ZSBUMTA0MnFkcy5kdHMgYW5kIGZvciBUMTA0MC5kdHMgaW5jbHVkZSB0
MTA0MmR0cyArIHN3aXRjaA0KDQoNCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL3BsYXRm
b3Jtcy84NXh4L3QxMDR4X3Fkcy5jDQo+ID4gYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgv
dDEwNHhfcWRzLmMNCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAu
LmQyOGRhMTQNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRm
b3Jtcy84NXh4L3QxMDR4X3Fkcy5jDQo+ID4gQEAgLTAsMCArMSwxMDIgQEANCj4gPiArLyoNCj4g
PiArICogVDEwNHggUURTIFNldHVwDQo+ID4gKyAqIFNob3VsZCBhcHBseSBmb3IgUURTIHBsYXRm
b3JtIG9mIFQxMDQwIGFuZCBpdCdzIHBlcnNvbmFsaXRpZXMuDQo+ID4gKyAqIHZpeiBUMTA0MC9U
MTA0Mg0KPiA+ICsgKg0KPiA+ICsgKiBDb3B5cmlnaHQgMjAxMyBGcmVlc2NhbGUgU2VtaWNvbmR1
Y3RvciBJbmMuDQo+ID4gKyAqDQo+ID4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJl
OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZQlpdCBhbmQvb3INCj4gbW9kaWZ5IGl0DQo+ID4gKyAqIHVu
ZGVyICB0aGUgdGVybXMgb2YJdGhlIEdOVSBHZW5lcmFsCSBQdWJsaWMgTGljZW5zZSBhcw0KPiBw
dWJsaXNoZWQgYnkgdGhlDQo+ID4gKyAqIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgIGVpdGhl
ciB2ZXJzaW9uIDIgb2YgdGhlICBMaWNlbnNlLCBvcg0KPiA+ICsoYXQgeW91cg0KPiA+ICsgKiBv
cHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KPiA+ICsgKi8NCj4gPiArDQo+ID4gKyNpbmNsdWRl
IDxsaW51eC9rZXJuZWwuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L3BjaS5oPg0KPiA+ICsjaW5j
bHVkZSA8bGludXgva2Rldl90Lmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9kZWxheS5oPg0KPiA+
ICsjaW5jbHVkZSA8bGludXgvaW50ZXJydXB0Lmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9waHku
aD4NCj4gPiArDQo+ID4gKyNpbmNsdWRlIDxhc20vdGltZS5oPg0KPiA+ICsjaW5jbHVkZSA8YXNt
L21hY2hkZXAuaD4NCj4gPiArI2luY2x1ZGUgPGFzbS9wY2ktYnJpZGdlLmg+DQo+ID4gKyNpbmNs
dWRlIDxtbS9tbXVfZGVjbC5oPg0KPiA+ICsjaW5jbHVkZSA8YXNtL3Byb20uaD4NCj4gPiArI2lu
Y2x1ZGUgPGFzbS91ZGJnLmg+DQo+ID4gKyNpbmNsdWRlIDxhc20vbXBpYy5oPg0KPiA+ICsNCj4g
PiArI2luY2x1ZGUgPGxpbnV4L29mX3BsYXRmb3JtLmg+DQo+ID4gKyNpbmNsdWRlIDxzeXNkZXYv
ZnNsX3NvYy5oPg0KPiA+ICsjaW5jbHVkZSA8c3lzZGV2L2ZzbF9wY2kuaD4NCj4gPiArI2luY2x1
ZGUgPGFzbS9laHZfcGljLmg+DQo+ID4gKw0KPiA+ICsjaW5jbHVkZSAiY29yZW5ldF9kcy5oIg0K
PiANCj4gWW91IGRvbid0IG5lZWQgYWxsIG9mIHRoZXNlIGluY2x1ZGVzLg0KPiANCj4gPiArZGVm
aW5lX21hY2hpbmUodDEwNHhfcWRzKSB7DQo+ID4gKwkubmFtZQkJCT0gIlQxMDR4IFFEUyIsDQo+
ID4gKwkucHJvYmUJCQk9IHQxMDR4X3Fkc19wcm9iZSwNCj4gDQo+IFNob3VsZCB3ZSBoYXZlIHR3
byBtYWNoaW5lIGRlc2NyaXB0aW9ucywgc28gdGhhdCB0aGUgcHJvcGVyIGNoaXAgbmFtZQ0KPiBz
aG93cyB1cCAoZS5nLiBpbiAvcHJvYy9jcHVpbmZvKT8NCj4gDQo+ID4gKy8qIGNvcmVpbnQgZG9l
c24ndCBwbGF5IG5pY2Ugd2l0aCBsYXp5IEVFLCB1c2UgbGVnYWN5IG1waWMgZm9yIG5vdyAqLw0K
PiA+ICsjaWZkZWYgQ09ORklHX1BQQzY0DQo+ID4gKwkuZ2V0X2lycQkJPSBtcGljX2dldF9pcnEs
DQo+ID4gKyNlbHNlDQo+ID4gKwkuZ2V0X2lycQkJPSBtcGljX2dldF9jb3JlaW50X2lycSwNCj4g
PiArI2VuZGlmDQo+IA0KPiBUaGlzIGlzbid0IHRydWUgYW55IG1vcmUuICBXaGVuIHN1Ym1pdHRp
bmcgY29kZSB0aGF0IHdhcyBjb3BpZWQgZnJvbQ0KPiBlbHNld2hlcmUsIHBsZWFzZSBjaGVjayB3
aGV0aGVyIHRoZXJlIHdlcmUgYW55IHVwZGF0ZXMgaW4gdGhlIGNvZGUgdGhhdA0KPiB5b3UgY29w
aWVkIGZyb20gKHVubGVzcyB5b3UgY29waWVkIGZyb20gYjRxZHMsIHdoaWNoIHRoZSB1cGRhdGUg
bWlzc2VkDQo+IC0tIEkganVzdCBzZW50IGEgcGF0Y2ggdG8gZml4IHRoYXQpLg0KPiANCg0KSSB3
aWxsIGNoZWNrIG9uIGxhdGVzdCBjb2RlIGJhc2UuDQoNClJlZ2FyZHMsDQpQcmFiaGFrYXINCg0K

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support
  2013-09-13  7:35   ` Kushwaha Prabhakar-B32579
@ 2013-09-16 20:44     ` Scott Wood
  0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2013-09-16 20:44 UTC (permalink / raw)
  To: Kushwaha Prabhakar-B32579
  Cc: Wood Scott-B07421, Jain Priyanka-B32167, Aggrwal Poonam-B10812,
	linuxppc-dev@lists.ozlabs.org

On Fri, 2013-09-13 at 02:35 -0500, Kushwaha Prabhakar-B32579 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, September 12, 2013 5:11 AM
> > To: Kushwaha Prabhakar-B32579
> > Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org; Jain
> > Priyanka-B32167; Aggrwal Poonam-B10812
> > Subject: Re: [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board
> > support
> > 
> > On Wed, 2013-09-11 at 12:28 +0530, Prabhakar Kushwaha wrote:
> > > +	aliases {
> > > +		 /* TODO */
> > > +		};
> > 
> > TODO?  Did you mean this patch as an RFC?
> > 
> 
> 
> actually, this patch is not adding in dpaa related node(fman,bman etc).
> I am keeping place holder for alias of Ethernet nodes. 

If you don't have any board-level aliases yet, then just don't include
the aliases node in this file.

> > Also, whitespace.
> > 
> 
> does whitespace is not captured in checkpatch?

Not in dts files.

> > Maybe some of this stuff could be put in a common dtsi between t1040 and
> > t1042?
> > 
> > Ideally for t1042 you'd just take the entire t1040 tree as an include,
> > and add the switch
> > 
> 
> means, I just create T1042qds.dts and for T1040.dts include t1042dts + switch

Is it t1040 that has the switch or t1042?

-Scott

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-16 20:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11  6:58 [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board support Prabhakar Kushwaha
2013-09-11 23:41 ` Scott Wood
2013-09-13  7:35   ` Kushwaha Prabhakar-B32579
2013-09-16 20:44     ` Scott Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).