* [PATCH] powerpc: net: filter: fix DIVWU instruction opcode
@ 2013-09-11 16:03 Vladimir Murzin
2013-09-12 0:32 ` Michael Neuling
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Murzin @ 2013-09-11 16:03 UTC (permalink / raw)
To: linuxppc-dev; +Cc: mikey, paulus, Vladimir Murzin, matt
Currently DIVWU stands for *signed* divw opcode:
7d 2a 4b 96 divwu r9,r10,r9
7d 2a 4b d6 divw r9,r10,r9
Use the *unsigned* divw opcode for DIVWU.
Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
---
arch/powerpc/include/asm/ppc-opcode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h
index d7fe9f5..c91842c 100644
--- a/arch/powerpc/include/asm/ppc-opcode.h
+++ b/arch/powerpc/include/asm/ppc-opcode.h
@@ -218,7 +218,7 @@
#define PPC_INST_MULLW 0x7c0001d6
#define PPC_INST_MULHWU 0x7c000016
#define PPC_INST_MULLI 0x1c000000
-#define PPC_INST_DIVWU 0x7c0003d6
+#define PPC_INST_DIVWU 0x7c000396
#define PPC_INST_RLWINM 0x54000000
#define PPC_INST_RLDICR 0x78000004
#define PPC_INST_SLW 0x7c000030
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: net: filter: fix DIVWU instruction opcode
2013-09-11 16:03 [PATCH] powerpc: net: filter: fix DIVWU instruction opcode Vladimir Murzin
@ 2013-09-12 0:32 ` Michael Neuling
2013-09-12 0:58 ` Matt Evans
0 siblings, 1 reply; 4+ messages in thread
From: Michael Neuling @ 2013-09-12 0:32 UTC (permalink / raw)
To: Vladimir Murzin; +Cc: linuxppc-dev, matt, paulus
Vladimir Murzin <murzin.v@gmail.com> wrote:
> Currently DIVWU stands for *signed* divw opcode:
>
> 7d 2a 4b 96 divwu r9,r10,r9
> 7d 2a 4b d6 divw r9,r10,r9
>
> Use the *unsigned* divw opcode for DIVWU.
This looks like it's in only used in the BPF JIT code.
Matt, any chance you an ACK/NACK this?
Mikey
>
> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> ---
> arch/powerpc/include/asm/ppc-opcode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h
> index d7fe9f5..c91842c 100644
> --- a/arch/powerpc/include/asm/ppc-opcode.h
> +++ b/arch/powerpc/include/asm/ppc-opcode.h
> @@ -218,7 +218,7 @@
> #define PPC_INST_MULLW 0x7c0001d6
> #define PPC_INST_MULHWU 0x7c000016
> #define PPC_INST_MULLI 0x1c000000
> -#define PPC_INST_DIVWU 0x7c0003d6
> +#define PPC_INST_DIVWU 0x7c000396
> #define PPC_INST_RLWINM 0x54000000
> #define PPC_INST_RLDICR 0x78000004
> #define PPC_INST_SLW 0x7c000030
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: net: filter: fix DIVWU instruction opcode
2013-09-12 0:32 ` Michael Neuling
@ 2013-09-12 0:58 ` Matt Evans
2013-09-12 2:52 ` Vladimir Murzin
0 siblings, 1 reply; 4+ messages in thread
From: Matt Evans @ 2013-09-12 0:58 UTC (permalink / raw)
To: Michael Neuling
Cc: Vladimir Murzin, linuxppc-dev@lists.ozlabs.org, paulus@samba.org
On 12 Sep 2013, at 10:02, Michael Neuling <mikey@neuling.org> wrote:
> Vladimir Murzin <murzin.v@gmail.com> wrote:
>=20
>> Currently DIVWU stands for *signed* divw opcode:
>>=20
>> 7d 2a 4b 96 divwu r9,r10,r9
>> 7d 2a 4b d6 divw r9,r10,r9
>>=20
>> Use the *unsigned* divw opcode for DIVWU.
>=20
> This looks like it's in only used in the BPF JIT code. =20
>=20
> Matt, any chance you an ACK/NACK this?
Sure, that looks sensible, thanks Vladimir.=20
Acked-by: Matt Evans <matt@ozlabs.org>
>=20
> Mikey
>=20
>>=20
>> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
>> ---
>> arch/powerpc/include/asm/ppc-opcode.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include=
/asm/ppc-opcode.h
>> index d7fe9f5..c91842c 100644
>> --- a/arch/powerpc/include/asm/ppc-opcode.h
>> +++ b/arch/powerpc/include/asm/ppc-opcode.h
>> @@ -218,7 +218,7 @@
>> #define PPC_INST_MULLW 0x7c0001d6
>> #define PPC_INST_MULHWU 0x7c000016
>> #define PPC_INST_MULLI 0x1c000000
>> -#define PPC_INST_DIVWU 0x7c0003d6
>> +#define PPC_INST_DIVWU 0x7c000396
>> #define PPC_INST_RLWINM 0x54000000
>> #define PPC_INST_RLDICR 0x78000004
>> #define PPC_INST_SLW 0x7c000030
>> --=20
>> 1.7.10.4
>>=20
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: net: filter: fix DIVWU instruction opcode
2013-09-12 0:58 ` Matt Evans
@ 2013-09-12 2:52 ` Vladimir Murzin
0 siblings, 0 replies; 4+ messages in thread
From: Vladimir Murzin @ 2013-09-12 2:52 UTC (permalink / raw)
To: Matt Evans
Cc: Michael Neuling, linuxppc-dev@lists.ozlabs.org, paulus@samba.org
On Thu, Sep 12, 2013 at 10:28:03AM +0930, Matt Evans wrote:
> On 12 Sep 2013, at 10:02, Michael Neuling <mikey@neuling.org> wrote:
>
> > Vladimir Murzin <murzin.v@gmail.com> wrote:
> >
> >> Currently DIVWU stands for *signed* divw opcode:
> >>
> >> 7d 2a 4b 96 divwu r9,r10,r9
> >> 7d 2a 4b d6 divw r9,r10,r9
> >>
> >> Use the *unsigned* divw opcode for DIVWU.
> >
> > This looks like it's in only used in the BPF JIT code.
> >
> > Matt, any chance you an ACK/NACK this?
>
> Sure, that looks sensible, thanks Vladimir.
>
> Acked-by: Matt Evans <matt@ozlabs.org>
>
Thanks!
Vladimir
> >
> > Mikey
> >
> >>
> >> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> >> ---
> >> arch/powerpc/include/asm/ppc-opcode.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h
> >> index d7fe9f5..c91842c 100644
> >> --- a/arch/powerpc/include/asm/ppc-opcode.h
> >> +++ b/arch/powerpc/include/asm/ppc-opcode.h
> >> @@ -218,7 +218,7 @@
> >> #define PPC_INST_MULLW 0x7c0001d6
> >> #define PPC_INST_MULHWU 0x7c000016
> >> #define PPC_INST_MULLI 0x1c000000
> >> -#define PPC_INST_DIVWU 0x7c0003d6
> >> +#define PPC_INST_DIVWU 0x7c000396
> >> #define PPC_INST_RLWINM 0x54000000
> >> #define PPC_INST_RLDICR 0x78000004
> >> #define PPC_INST_SLW 0x7c000030
> >> --
> >> 1.7.10.4
> >>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-12 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 16:03 [PATCH] powerpc: net: filter: fix DIVWU instruction opcode Vladimir Murzin
2013-09-12 0:32 ` Michael Neuling
2013-09-12 0:58 ` Matt Evans
2013-09-12 2:52 ` Vladimir Murzin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).