From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d
Date: Sat, 28 Sep 2013 13:05:50 +1000 [thread overview]
Message-ID: <1380337550.27811.71.camel@pasglop> (raw)
In-Reply-To: <CAE9FiQV8ipnQ_vV68S-QHMrUrQTWQT_XObxyBeR=dOuw6fG1eg@mail.gmail.com>
On Fri, 2013-09-27 at 16:44 -0700, Yinghai Lu wrote:
> > Thus the port driver bails out before calling pci_set_master(). The fix
> > is to call pci_set_master() unconditionally. However that lead me to
> > find to a few interesting oddities in that port driver code:
>
> can we revert that partially change ? aka we should check get_port....
> at first...
>
> like attached.
In the meantime, can you properly submit the other one with the warning
to Linus ? It will make things more robust overall...
Also, please read my other comments. I think we are treading on very
fragile ground with that whole business of potentially disabling bridges
in the pcieport driver ...
Cheers,
Ben.
next prev parent reply other threads:[~2013-09-28 3:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 8:28 Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d Benjamin Herrenschmidt
2013-09-27 16:01 ` Yinghai Lu
2013-09-27 17:10 ` Linus Torvalds
2013-09-27 21:46 ` Benjamin Herrenschmidt
2013-09-27 21:54 ` Yinghai Lu
2013-09-27 22:00 ` Benjamin Herrenschmidt
2013-09-27 22:38 ` Benjamin Herrenschmidt
2013-09-27 22:56 ` Yinghai Lu
2013-09-27 23:19 ` Benjamin Herrenschmidt
2013-09-27 23:44 ` Yinghai Lu
2013-09-28 3:05 ` Benjamin Herrenschmidt [this message]
2013-09-28 20:14 ` Yinghai Lu
2013-09-29 0:40 ` Rafael J. Wysocki
2013-09-27 17:44 ` Yinghai Lu
2013-09-27 22:15 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380337550.27811.71.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).