* [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 @ 2013-10-02 14:38 Aneesh Kumar K.V 2013-10-03 4:14 ` Paul Mackerras 0 siblings, 1 reply; 9+ messages in thread From: Aneesh Kumar K.V @ 2013-10-02 14:38 UTC (permalink / raw) To: agraf, benh, paulus; +Cc: linuxppc-dev, kvm, kvm-ppc, Aneesh Kumar K.V From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> --- arch/powerpc/kvm/book3s_pr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c index 8941885..6075dbd 100644 --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c @@ -1179,7 +1179,7 @@ struct kvm_vcpu *kvmppc_core_vcpu_create(struct kvm *kvm, unsigned int id) #ifdef CONFIG_KVM_BOOK3S_32 vcpu->arch.shadow_vcpu = - kzalloc(sizeof(*vcpu_book3s->shadow_vcpu), GFP_KERNEL); + kzalloc(sizeof(*vcpu->arch.shadow_vcpu), GFP_KERNEL); if (!vcpu->arch.shadow_vcpu) goto free_vcpu3s; #endif -- 1.8.1.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-02 14:38 [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Aneesh Kumar K.V @ 2013-10-03 4:14 ` Paul Mackerras 2013-10-04 12:23 ` Alexander Graf 0 siblings, 1 reply; 9+ messages in thread From: Paul Mackerras @ 2013-10-03 4:14 UTC (permalink / raw) To: Aneesh Kumar K.V; +Cc: linuxppc-dev, agraf, kvm-ppc, kvm On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b It's a good idea to give the headline of the commit as well as the ID. I also like to trim the ID to 10 characters or so. So it should look like this: This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate kvm_vcpu structs from kvm_vcpu_cache"). > arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Acked-by: Paul Mackerras <paulus@samba.org> Paul. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-03 4:14 ` Paul Mackerras @ 2013-10-04 12:23 ` Alexander Graf 2013-10-04 12:27 ` Alexander Graf 0 siblings, 1 reply; 9+ messages in thread From: Alexander Graf @ 2013-10-04 12:23 UTC (permalink / raw) To: Paul Mackerras; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On 03.10.2013, at 06:14, Paul Mackerras wrote: > On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >>=20 >> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >=20 > It's a good idea to give the headline of the commit as well as the ID. > I also like to trim the ID to 10 characters or so. So it should look > like this: >=20 > This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate > kvm_vcpu structs from kvm_vcpu_cache"). >=20 >> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': >> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct = kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>=20 >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> >=20 > Acked-by: Paul Mackerras <paulus@samba.org> Would you guys mind if I merge this into the offending patch? It's not = trickled into -next yet, so rebasing should work. If not, please resend with the fixed commit message. Alex ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 12:23 ` Alexander Graf @ 2013-10-04 12:27 ` Alexander Graf 2013-10-04 12:35 ` Paul Mackerras 2013-10-04 14:24 ` Aneesh Kumar K.V 0 siblings, 2 replies; 9+ messages in thread From: Alexander Graf @ 2013-10-04 12:27 UTC (permalink / raw) To: Paul Mackerras; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On 04.10.2013, at 14:23, Alexander Graf wrote: >=20 > On 03.10.2013, at 06:14, Paul Mackerras wrote: >=20 >> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >>>=20 >>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >>=20 >> It's a good idea to give the headline of the commit as well as the = ID. >> I also like to trim the ID to 10 characters or so. So it should look >> like this: >>=20 >> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate >> kvm_vcpu structs from kvm_vcpu_cache"). >>=20 >>> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': >>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct = kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>>=20 >>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> >>=20 >> Acked-by: Paul Mackerras <paulus@samba.org> >=20 > Would you guys mind if I merge this into the offending patch? It's not = trickled into -next yet, so rebasing should work. >=20 > If not, please resend with the fixed commit message. Eh - I must've missed v2 :). So that leaves only the question on whether = you'd be ok to squash the patch instead. It'd help bisectability. Alex ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 12:27 ` Alexander Graf @ 2013-10-04 12:35 ` Paul Mackerras 2013-10-04 13:00 ` Alexander Graf 2013-10-04 14:24 ` Aneesh Kumar K.V 1 sibling, 1 reply; 9+ messages in thread From: Paul Mackerras @ 2013-10-04 12:35 UTC (permalink / raw) To: Alexander Graf; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On Fri, Oct 04, 2013 at 02:27:02PM +0200, Alexander Graf wrote: > > On 04.10.2013, at 14:23, Alexander Graf wrote: > > > > > On 03.10.2013, at 06:14, Paul Mackerras wrote: > > > >> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > >>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > >>> > >>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b > >> > >> It's a good idea to give the headline of the commit as well as the ID. > >> I also like to trim the ID to 10 characters or so. So it should look > >> like this: > >> > >> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate > >> kvm_vcpu structs from kvm_vcpu_cache"). > >> > >>> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > >>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > >>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > >>> > >>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > >> > >> Acked-by: Paul Mackerras <paulus@samba.org> > > > > Would you guys mind if I merge this into the offending patch? It's not trickled into -next yet, so rebasing should work. > > > > If not, please resend with the fixed commit message. > > Eh - I must've missed v2 :). So that leaves only the question on whether you'd be ok to squash the patch instead. It'd help bisectability. I'm OK with that. If you do, why don't you squash the first of the two patches that I just sent into the commit it fixes as well? Paul. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 12:35 ` Paul Mackerras @ 2013-10-04 13:00 ` Alexander Graf 2013-10-04 23:45 ` Paul Mackerras 0 siblings, 1 reply; 9+ messages in thread From: Alexander Graf @ 2013-10-04 13:00 UTC (permalink / raw) To: Paul Mackerras; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On 04.10.2013, at 14:35, Paul Mackerras wrote: > On Fri, Oct 04, 2013 at 02:27:02PM +0200, Alexander Graf wrote: >>=20 >> On 04.10.2013, at 14:23, Alexander Graf wrote: >>=20 >>>=20 >>> On 03.10.2013, at 06:14, Paul Mackerras wrote: >>>=20 >>>> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >>>>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >>>>>=20 >>>>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >>>>=20 >>>> It's a good idea to give the headline of the commit as well as the = ID. >>>> I also like to trim the ID to 10 characters or so. So it should = look >>>> like this: >>>>=20 >>>> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate >>>> kvm_vcpu structs from kvm_vcpu_cache"). >>>>=20 >>>>> arch/powerpc/kvm/book3s_pr.c: In function = 'kvmppc_core_vcpu_create': >>>>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct = kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >>>>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>>>>=20 >>>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> >>>>=20 >>>> Acked-by: Paul Mackerras <paulus@samba.org> >>>=20 >>> Would you guys mind if I merge this into the offending patch? It's = not trickled into -next yet, so rebasing should work. >>>=20 >>> If not, please resend with the fixed commit message. >>=20 >> Eh - I must've missed v2 :). So that leaves only the question on = whether you'd be ok to squash the patch instead. It'd help = bisectability. >=20 > I'm OK with that. If you do, why don't you squash the first of the > two patches that I just sent into the commit it fixes as well? Because patch 1/2 spans two separate commits it would have to get = squashed into (6aa82e, 70afec) and patch 2/2 doesn't make sense to get = squashed anywhere :). Alex ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 13:00 ` Alexander Graf @ 2013-10-04 23:45 ` Paul Mackerras 2013-10-04 23:59 ` Alexander Graf 0 siblings, 1 reply; 9+ messages in thread From: Paul Mackerras @ 2013-10-04 23:45 UTC (permalink / raw) To: Alexander Graf; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On Fri, Oct 04, 2013 at 03:00:11PM +0200, Alexander Graf wrote: > > On 04.10.2013, at 14:35, Paul Mackerras wrote: > > > On Fri, Oct 04, 2013 at 02:27:02PM +0200, Alexander Graf wrote: > >> > >> On 04.10.2013, at 14:23, Alexander Graf wrote: > >> > >>> > >>> On 03.10.2013, at 06:14, Paul Mackerras wrote: > >>> > >>>> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > >>>>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > >>>>> > >>>>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b > >>>> > >>>> It's a good idea to give the headline of the commit as well as the ID. > >>>> I also like to trim the ID to 10 characters or so. So it should look > >>>> like this: > >>>> > >>>> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate > >>>> kvm_vcpu structs from kvm_vcpu_cache"). > >>>> > >>>>> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > >>>>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > >>>>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > >>>>> > >>>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > >>>> > >>>> Acked-by: Paul Mackerras <paulus@samba.org> > >>> > >>> Would you guys mind if I merge this into the offending patch? It's not trickled into -next yet, so rebasing should work. > >>> > >>> If not, please resend with the fixed commit message. > >> > >> Eh - I must've missed v2 :). So that leaves only the question on whether you'd be ok to squash the patch instead. It'd help bisectability. > > > > I'm OK with that. If you do, why don't you squash the first of the > > two patches that I just sent into the commit it fixes as well? > > Because patch 1/2 spans two separate commits it would have to get squashed into (6aa82e, 70afec) and patch 2/2 doesn't make sense to get squashed anywhere :). Actually 70afec is fine, if you look at it, it's only 6aa82e that needs fixing. Paul. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 23:45 ` Paul Mackerras @ 2013-10-04 23:59 ` Alexander Graf 0 siblings, 0 replies; 9+ messages in thread From: Alexander Graf @ 2013-10-04 23:59 UTC (permalink / raw) To: Paul Mackerras; +Cc: linuxppc-dev, Aneesh Kumar K.V, kvm-ppc, kvm On 05.10.2013, at 01:45, Paul Mackerras wrote: > On Fri, Oct 04, 2013 at 03:00:11PM +0200, Alexander Graf wrote: >>=20 >> On 04.10.2013, at 14:35, Paul Mackerras wrote: >>=20 >>> On Fri, Oct 04, 2013 at 02:27:02PM +0200, Alexander Graf wrote: >>>>=20 >>>> On 04.10.2013, at 14:23, Alexander Graf wrote: >>>>=20 >>>>>=20 >>>>> On 03.10.2013, at 06:14, Paul Mackerras wrote: >>>>>=20 >>>>>> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >>>>>>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >>>>>>>=20 >>>>>>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >>>>>>=20 >>>>>> It's a good idea to give the headline of the commit as well as = the ID. >>>>>> I also like to trim the ID to 10 characters or so. So it should = look >>>>>> like this: >>>>>>=20 >>>>>> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate >>>>>> kvm_vcpu structs from kvm_vcpu_cache"). >>>>>>=20 >>>>>>> arch/powerpc/kvm/book3s_pr.c: In function = 'kvmppc_core_vcpu_create': >>>>>>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct = kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >>>>>>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>>>>>>=20 >>>>>>> Signed-off-by: Aneesh Kumar K.V = <aneesh.kumar@linux.vnet.ibm.com> >>>>>>=20 >>>>>> Acked-by: Paul Mackerras <paulus@samba.org> >>>>>=20 >>>>> Would you guys mind if I merge this into the offending patch? It's = not trickled into -next yet, so rebasing should work. >>>>>=20 >>>>> If not, please resend with the fixed commit message. >>>>=20 >>>> Eh - I must've missed v2 :). So that leaves only the question on = whether you'd be ok to squash the patch instead. It'd help = bisectability. >>>=20 >>> I'm OK with that. If you do, why don't you squash the first of the >>> two patches that I just sent into the commit it fixes as well? >>=20 >> Because patch 1/2 spans two separate commits it would have to get = squashed into (6aa82e, 70afec) and patch 2/2 doesn't make sense to get = squashed anywhere :). >=20 > Actually 70afec is fine, if you look at it, it's only 6aa82e that > needs fixing. True. Squashed them :). Alex ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 2013-10-04 12:27 ` Alexander Graf 2013-10-04 12:35 ` Paul Mackerras @ 2013-10-04 14:24 ` Aneesh Kumar K.V 1 sibling, 0 replies; 9+ messages in thread From: Aneesh Kumar K.V @ 2013-10-04 14:24 UTC (permalink / raw) To: Alexander Graf, Paul Mackerras; +Cc: linuxppc-dev, kvm, kvm-ppc Alexander Graf <agraf@suse.de> writes: > On 04.10.2013, at 14:23, Alexander Graf wrote: > >> >> On 03.10.2013, at 06:14, Paul Mackerras wrote: >> >>> On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: >>>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >>>> >>>> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b >>> >>> It's a good idea to give the headline of the commit as well as the ID. >>> I also like to trim the ID to 10 characters or so. So it should look >>> like this: >>> >>> This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate >>> kvm_vcpu structs from kvm_vcpu_cache"). >>> >>>> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': >>>> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' >>>> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 >>>> >>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> >>> >>> Acked-by: Paul Mackerras <paulus@samba.org> >> >> Would you guys mind if I merge this into the offending patch? It's not trickled into -next yet, so rebasing should work. >> >> If not, please resend with the fixed commit message. > > Eh - I must've missed v2 :). So that leaves only the question on whether you'd be ok to squash the patch instead. It'd help bisectability. Yes, it should be squashed if we can do that. -aneesh ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-04 23:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-02 14:38 [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Aneesh Kumar K.V 2013-10-03 4:14 ` Paul Mackerras 2013-10-04 12:23 ` Alexander Graf 2013-10-04 12:27 ` Alexander Graf 2013-10-04 12:35 ` Paul Mackerras 2013-10-04 13:00 ` Alexander Graf 2013-10-04 23:45 ` Paul Mackerras 2013-10-04 23:59 ` Alexander Graf 2013-10-04 14:24 ` Aneesh Kumar K.V
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).