* [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check
@ 2013-10-03 4:15 Guenter Roeck
2013-10-03 15:58 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2013-10-03 4:15 UTC (permalink / raw)
To: alsa-devel
Cc: Timur Tabi, Takashi Iwai, linux-kernel, Liam Girdwood,
Jaroslav Kysela, Mark Brown, Geert Uytterhoeven, Grant Likely,
linuxppc-dev, Guenter Roeck
irq_of_parse_and_map() returns 0 on error, not NO_IRQ.
Fix the following xtensa:allmodconfig build error.
sound/soc/fsl/fsl_ssi.c:705:26: error: 'NO_IRQ' undeclared (first use in this function)
make[4]: *** [sound/soc/fsl/fsl_ssi.o] Error 1
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Previously submitted by Grant Likely as part of a different patch set.
See https://lkml.org/lkml/2012/1/11/342.
Also see https://lkml.org/lkml/2013/7/25/642.
sound/soc/fsl/fsl_ssi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index c6b7439..6b81d0c 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -936,7 +936,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
ssi_private->ssi_phys = res.start;
ssi_private->irq = irq_of_parse_and_map(np, 0);
- if (ssi_private->irq == NO_IRQ) {
+ if (ssi_private->irq == 0) {
dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
return -ENXIO;
}
--
1.7.9.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check
2013-10-03 4:15 [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check Guenter Roeck
@ 2013-10-03 15:58 ` Mark Brown
2013-10-17 1:57 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2013-10-03 15:58 UTC (permalink / raw)
To: Guenter Roeck
Cc: alsa-devel, Timur Tabi, Takashi Iwai, linux-kernel, Liam Girdwood,
Jaroslav Kysela, Geert Uytterhoeven, Grant Likely, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
On Wed, Oct 02, 2013 at 09:15:22PM -0700, Guenter Roeck wrote:
> irq_of_parse_and_map() returns 0 on error, not NO_IRQ.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check
2013-10-03 15:58 ` Mark Brown
@ 2013-10-17 1:57 ` Guenter Roeck
2013-10-17 9:40 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2013-10-17 1:57 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Timur Tabi, Takashi Iwai, linux-kernel, Liam Girdwood,
Jaroslav Kysela, Geert Uytterhoeven, Grant Likely, linuxppc-dev
On 10/03/2013 08:58 AM, Mark Brown wrote:
> On Wed, Oct 02, 2013 at 09:15:22PM -0700, Guenter Roeck wrote:
>> irq_of_parse_and_map() returns 0 on error, not NO_IRQ.
>
> Applied, thanks.
>
Hi Mark,
do you plan to send this patch upstream anytime soon ?
It fixes an xtensa build problem, so it would be great if it could find its way into 3.13.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check
2013-10-17 1:57 ` Guenter Roeck
@ 2013-10-17 9:40 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-10-17 9:40 UTC (permalink / raw)
To: Guenter Roeck
Cc: alsa-devel, Timur Tabi, Takashi Iwai, linux-kernel, Liam Girdwood,
Jaroslav Kysela, Geert Uytterhoeven, Grant Likely, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
On Wed, Oct 16, 2013 at 06:57:53PM -0700, Guenter Roeck wrote:
> do you plan to send this patch upstream anytime soon ?
It'll go next time I send stuff if it hasn't already.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-17 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-03 4:15 [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check Guenter Roeck
2013-10-03 15:58 ` Mark Brown
2013-10-17 1:57 ` Guenter Roeck
2013-10-17 9:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).