From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/powernv: Add a debugfs file to read the firmware console
Date: Wed, 09 Oct 2013 17:51:52 +1100 [thread overview]
Message-ID: <1381301512.645.272.camel@pasglop> (raw)
In-Reply-To: <20131009060613.GC28160@concordia>
On Wed, 2013-10-09 at 17:06 +1100, Michael Ellerman wrote:
> Call it twice.
>
> And you wonder why no one reviews your patches?
Not that easy :-) I had a look at using it and unless I did something
stupid, it wasn't actually that trivial to figure out what arg to pass
it for calling it twice, ie, it didn't simplify the code
significantly ... I had another problem too but I don't remember what
it was. But it could be that I had a very dumb moment...
Cheers,
Ben.
prev parent reply other threads:[~2013-10-09 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 7:46 [PATCH] powerpc/powernv: Add a debugfs file to read the firmware console Benjamin Herrenschmidt
2013-10-09 3:23 ` Michael Ellerman
2013-10-09 4:23 ` Benjamin Herrenschmidt
2013-10-09 6:06 ` Michael Ellerman
2013-10-09 6:51 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381301512.645.272.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).