* [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies
@ 2013-10-28 11:26 Christian Kujau
2013-10-29 23:13 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Christian Kujau @ 2013-10-28 11:26 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Geert Uytterhoeven
Hi,
for quite some time the following is printed (twice) after doing
"make oldconfig":
[...]
scripts/kconfig/conf --oldconfig Kconfig
warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS)
warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS)
I never got around to look into this. But I remember that (when I still
had CONFIG_IDE selected, because CONFIG_PATA_MACIO was not working for my
PowerBook G5), I always had ADB_PMU_LED_IDE selected, so this option was
carried over to my current config.
When doing "make menuconfig" with this generated config I could see that
all 3 necessary options are selected:
Support for PMU based PowerMacs CONFIG_ADB_PMU
Support for the Power/iBook front LED CONFIG_ADB_PMU_LED
Use front LED as IDE LED by default CONFIG_ADB_PMU_LED_IDE
And CONFIG_ADB_PMU_LED_IDE selects CONFIG_LEDS_TRIGGER_IDE_DISK, which in
turn depends on CONFIG_IDE_GD_ATA - but in "make menuconfig" I could still
*unselect* CONFIG_IDE (since I'm using CONFIG_PATA_MACIO) and the 3
options above were still available. I guess "make oldconfig" noticed that
and hence printed the warning above.
The following patch causes ADB_PMU_LED to depend on IDE_GD_ATA, so that
the options above are only available when IDE_GD_ATA is actually selected
and thus eliminates the warning.
Signed-off-by: Christian Kujau <lists@nerdbynature.de>
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 696238b..f30ac9d 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -90,6 +90,7 @@ config ADB_PMU
config ADB_PMU_LED
bool "Support for the Power/iBook front LED"
depends on ADB_PMU
+ depends on IDE_GD_ATA
select NEW_LEDS
select LEDS_CLASS
help
Being a kbuild n00b, I don't know if this is the correct approach though.
After looking through the archives I found that this has been reported by
Geert back in 2012 already: https://lkml.org/lkml/2012/3/13/556
Thanks,
Christian.
--
BOFH excuse #186:
permission denied
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies
2013-10-28 11:26 [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies Christian Kujau
@ 2013-10-29 23:13 ` Benjamin Herrenschmidt
2013-10-30 4:25 ` Christian Kujau
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2013-10-29 23:13 UTC (permalink / raw)
To: Christian Kujau; +Cc: Geert Uytterhoeven, linuxppc-dev
On Mon, 2013-10-28 at 04:26 -0700, Christian Kujau wrote:
> Hi,
>
> for quite some time the following is printed (twice) after doing
> "make oldconfig":
>
> [...]
> scripts/kconfig/conf --oldconfig Kconfig
> warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS)
> warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS)
>
> I never got around to look into this. But I remember that (when I still
> had CONFIG_IDE selected, because CONFIG_PATA_MACIO was not working for my
> PowerBook G5), I always had ADB_PMU_LED_IDE selected, so this option was
> carried over to my current config.
>
> When doing "make menuconfig" with this generated config I could see that
> all 3 necessary options are selected:
>
> Support for PMU based PowerMacs CONFIG_ADB_PMU
> Support for the Power/iBook front LED CONFIG_ADB_PMU_LED
> Use front LED as IDE LED by default CONFIG_ADB_PMU_LED_IDE
>
> And CONFIG_ADB_PMU_LED_IDE selects CONFIG_LEDS_TRIGGER_IDE_DISK, which in
> turn depends on CONFIG_IDE_GD_ATA - but in "make menuconfig" I could still
> *unselect* CONFIG_IDE (since I'm using CONFIG_PATA_MACIO) and the 3
> options above were still available. I guess "make oldconfig" noticed that
> and hence printed the warning above.
>
> The following patch causes ADB_PMU_LED to depend on IDE_GD_ATA, so that
> the options above are only available when IDE_GD_ATA is actually selected
> and thus eliminates the warning.
>
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>
>
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 696238b..f30ac9d 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -90,6 +90,7 @@ config ADB_PMU
> config ADB_PMU_LED
> bool "Support for the Power/iBook front LED"
> depends on ADB_PMU
> + depends on IDE_GD_ATA
> select NEW_LEDS
> select LEDS_CLASS
> help
You probably want to do that to the ADB_PMU_LED_IDE entry not the
ADB_PMU_LED one which doesn't have a dependency and isn't the one
selecting LEDS_TRIGGER_IDE_DISK :-)
Cheers,
Ben.
>
> Being a kbuild n00b, I don't know if this is the correct approach though.
>
> After looking through the archives I found that this has been reported by
> Geert back in 2012 already: https://lkml.org/lkml/2012/3/13/556
>
> Thanks,
> Christian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies
2013-10-29 23:13 ` Benjamin Herrenschmidt
@ 2013-10-30 4:25 ` Christian Kujau
2013-10-31 1:37 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Christian Kujau @ 2013-10-30 4:25 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Geert Uytterhoeven, linuxppc-dev
On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
> You probably want to do that to the ADB_PMU_LED_IDE entry not the
> ADB_PMU_LED one which doesn't have a dependency and isn't the one
> selecting LEDS_TRIGGER_IDE_DISK :-)
Right you are, sorry for the mixup. Let me try again:
Signed-off-by: Christian Kujau <lists@nerdbynature.de>
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 696238b..d26a312 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -103,6 +103,7 @@ config ADB_PMU_LED_IDE
bool "Use front LED as IDE LED by default"
depends on ADB_PMU_LED
depends on LEDS_CLASS
+ depends on IDE_GD_ATA
select LEDS_TRIGGERS
select LEDS_TRIGGER_IDE_DISK
help
C.
--
BOFH excuse #378:
Operators killed by year 2000 bug bite.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies
2013-10-30 4:25 ` Christian Kujau
@ 2013-10-31 1:37 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2013-10-31 1:37 UTC (permalink / raw)
To: Christian Kujau; +Cc: Geert Uytterhoeven, linuxppc-dev
On Tue, 2013-10-29 at 21:25 -0700, Christian Kujau wrote:
> On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
> > You probably want to do that to the ADB_PMU_LED_IDE entry not the
> > ADB_PMU_LED one which doesn't have a dependency and isn't the one
> > selecting LEDS_TRIGGER_IDE_DISK :-)
>
> Right you are, sorry for the mixup. Let me try again:
And this time without a changeset comment ? :-)
I've copied it from the previous version but next time, re-send the
complete commit.
Cheers,
Ben.
>
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>
>
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 696238b..d26a312 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -103,6 +103,7 @@ config ADB_PMU_LED_IDE
> bool "Use front LED as IDE LED by default"
> depends on ADB_PMU_LED
> depends on LEDS_CLASS
> + depends on IDE_GD_ATA
> select LEDS_TRIGGERS
> select LEDS_TRIGGER_IDE_DISK
> help
>
> C.
> --
> BOFH excuse #378:
>
> Operators killed by year 2000 bug bite.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-31 1:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-28 11:26 [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies Christian Kujau
2013-10-29 23:13 ` Benjamin Herrenschmidt
2013-10-30 4:25 ` Christian Kujau
2013-10-31 1:37 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).