From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies
Date: Thu, 31 Oct 2013 12:37:07 +1100 [thread overview]
Message-ID: <1383183427.5117.73.camel@pasglop> (raw)
In-Reply-To: <alpine.DEB.2.11.1310292123190.31521@trent.utfs.org>
On Tue, 2013-10-29 at 21:25 -0700, Christian Kujau wrote:
> On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
> > You probably want to do that to the ADB_PMU_LED_IDE entry not the
> > ADB_PMU_LED one which doesn't have a dependency and isn't the one
> > selecting LEDS_TRIGGER_IDE_DISK :-)
>
> Right you are, sorry for the mixup. Let me try again:
And this time without a changeset comment ? :-)
I've copied it from the previous version but next time, re-send the
complete commit.
Cheers,
Ben.
>
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>
>
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 696238b..d26a312 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -103,6 +103,7 @@ config ADB_PMU_LED_IDE
> bool "Use front LED as IDE LED by default"
> depends on ADB_PMU_LED
> depends on LEDS_CLASS
> + depends on IDE_GD_ATA
> select LEDS_TRIGGERS
> select LEDS_TRIGGER_IDE_DISK
> help
>
> C.
> --
> BOFH excuse #378:
>
> Operators killed by year 2000 bug bite.
prev parent reply other threads:[~2013-10-31 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 11:26 [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies Christian Kujau
2013-10-29 23:13 ` Benjamin Herrenschmidt
2013-10-30 4:25 ` Christian Kujau
2013-10-31 1:37 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383183427.5117.73.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lists@nerdbynature.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).