linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
	Liu Ping Fan <kernelfans@gmail.com>
Subject: Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment
Date: Thu, 07 Nov 2013 06:58:50 +1100	[thread overview]
Message-ID: <1383767930.4776.125.camel@pasglop> (raw)
In-Reply-To: <740542A8-47BC-4015-8675-D36C72F5837D@suse.de>

On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote:
> On 05.11.2013, at 08:42, Liu Ping Fan <kernelfans@gmail.com> wrote:
> 
> > Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> 
> Patch description missing.

Do you really need a description for trivial one-lines whose subject
is a perfectly complete description already ?

> Please add Paul's ack in the next revision of this patch :).
> 
> 
> Alex
> 
> > ---
> > arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > index 28160ac..7682837 100644
> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > @@ -731,7 +731,6 @@ int kvmppc_book3s_hv_page_fault(struct kvm_run *run, struct kvm_vcpu *vcpu,
> > 	lock_rmap(rmap);
> > 
> > 	/* Check if we might have been invalidated; let the guest retry if so */
> > -	ret = RESUME_GUEST;
> > 	if (mmu_notifier_retry(vcpu->kvm, mmu_seq)) {
> > 		unlock_rmap(rmap);
> > 		goto out_unlock;
> > -- 
> > 1.8.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-11-06 19:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05  7:42 [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Liu Ping Fan
2013-11-05  7:42 ` [PATCH 2/3] powerpc/kvm: fix rare but potential deadlock scene Liu Ping Fan
2013-11-06  5:04   ` Paul Mackerras
2013-11-06  6:02     ` Liu ping fan
2013-11-06 11:18       ` Paul Mackerras
2013-11-07  2:36         ` Liu ping fan
2013-11-05  7:42 ` [PATCH 3/3] powerpc/kvm: remove redundant assignment Liu Ping Fan
2013-11-06  5:04   ` Paul Mackerras
2013-11-06 11:24   ` Alexander Graf
2013-11-06 19:58     ` Benjamin Herrenschmidt [this message]
2013-11-07  7:52       ` Alexander Graf
2013-11-07  7:55         ` Benjamin Herrenschmidt
2013-11-07  8:14           ` Alexander Graf
2013-11-07  8:36             ` Benjamin Herrenschmidt
2013-11-06  5:01 ` [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Paul Mackerras
2013-11-06  7:26   ` Liu ping fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383767930.4776.125.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=kernelfans@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).