From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
Liu Ping Fan <kernelfans@gmail.com>
Subject: Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment
Date: Thu, 07 Nov 2013 19:36:04 +1100 [thread overview]
Message-ID: <1383813364.4776.172.camel@pasglop> (raw)
In-Reply-To: <D41E9B02-613E-498D-B68B-18FCAC21637F@suse.de>
On Thu, 2013-11-07 at 09:14 +0100, Alexander Graf wrote:
> > And ? An explanation isn't going to be clearer than the code in that
> > case ...
>
> It's pretty non-obvious when you do a git show on that patch in 1 year
> from now, as the redundancy is out of scope of what the diff shows.
And ? How would an explanation help ?
Either it's redundant or it's not ... but only look at the code can
prove it. An explanation won't because if the patch is wrong, so will be
the explanation.
Cheers,
Ben.
next prev parent reply other threads:[~2013-11-07 8:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 7:42 [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Liu Ping Fan
2013-11-05 7:42 ` [PATCH 2/3] powerpc/kvm: fix rare but potential deadlock scene Liu Ping Fan
2013-11-06 5:04 ` Paul Mackerras
2013-11-06 6:02 ` Liu ping fan
2013-11-06 11:18 ` Paul Mackerras
2013-11-07 2:36 ` Liu ping fan
2013-11-05 7:42 ` [PATCH 3/3] powerpc/kvm: remove redundant assignment Liu Ping Fan
2013-11-06 5:04 ` Paul Mackerras
2013-11-06 11:24 ` Alexander Graf
2013-11-06 19:58 ` Benjamin Herrenschmidt
2013-11-07 7:52 ` Alexander Graf
2013-11-07 7:55 ` Benjamin Herrenschmidt
2013-11-07 8:14 ` Alexander Graf
2013-11-07 8:36 ` Benjamin Herrenschmidt [this message]
2013-11-06 5:01 ` [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Paul Mackerras
2013-11-06 7:26 ` Liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383813364.4776.172.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=kernelfans@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).