From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 924DD2C00C4 for ; Thu, 7 Nov 2013 19:36:42 +1100 (EST) Message-ID: <1383813364.4776.172.camel@pasglop> Subject: Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment From: Benjamin Herrenschmidt To: Alexander Graf Date: Thu, 07 Nov 2013 19:36:04 +1100 In-Reply-To: References: <1383637364-14691-1-git-send-email-pingfank@linux.vnet.ibm.com> <1383637364-14691-3-git-send-email-pingfank@linux.vnet.ibm.com> <740542A8-47BC-4015-8675-D36C72F5837D@suse.de> <1383767930.4776.125.camel@pasglop> <92DFDE0F-0E72-41F9-9562-3EC0CA5BD2B1@suse.de> <1383810909.4776.171.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Paul Mackerras , "linuxppc-dev@lists.ozlabs.org" , "kvm-ppc@vger.kernel.org" , Liu Ping Fan List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2013-11-07 at 09:14 +0100, Alexander Graf wrote: > > And ? An explanation isn't going to be clearer than the code in that > > case ... > > It's pretty non-obvious when you do a git show on that patch in 1 year > from now, as the redundancy is out of scope of what the diff shows. And ? How would an explanation help ? Either it's redundant or it's not ... but only look at the code can prove it. An explanation won't because if the patch is wrong, so will be the explanation. Cheers, Ben.