From: Li Zhong <zhong@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: PowerPC email list <linuxppc-dev@lists.ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC PATCH powerpc] Fix compiling error in powernv/rng.c
Date: Tue, 19 Nov 2013 17:24:19 +0800 [thread overview]
Message-ID: <1384853059.2511.25.camel@ThinkPad-T5421> (raw)
In-Reply-To: <20131119040455.GB27740@concordia>
On Tue, 2013-11-19 at 15:04 +1100, Michael Ellerman wrote:
> On Fri, Nov 15, 2013 at 03:36:04PM +0800, Li Zhong wrote:
> > This is seen when CONFIG_SMP is not enabled:
> >
> > arch/powerpc/platforms/powernv/rng.c: In function 'rng_init_per_cpu':
> > arch/powerpc/platforms/powernv/rng.c:74: error: implicit declaration of function 'cpu_to_chip_id'
>
> Hi Li,
>
> We try whenever possible to avoid adding #ifdefs in C code.
>
> Also on a multi chip system where there are multiple RNGs, your code for
> UP will not necessarily choose the RNG on the same core as the cpu.
OK, thank you for the review, Michael.
Just try to make sure I understand it:
So even in UP, we could have multiple rng sources, and we should try to
use the source which has the same chip_id as the logical cpu?
Thanks, Zhong
> I have a different fix that I will send.
>
> cheers
>
prev parent reply other threads:[~2013-11-19 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 7:36 [RFC PATCH powerpc] Fix compiling error in powernv/rng.c Li Zhong
2013-11-19 4:04 ` Michael Ellerman
2013-11-19 9:24 ` Li Zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384853059.2511.25.camel@ThinkPad-T5421 \
--to=zhong@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox