From: Geoff Levand <geoff@infradead.org>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
Eric Biederman <ebiederm@xmission.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] kexec: Add IND_FLAGS macro
Date: Thu, 12 Dec 2013 11:33:50 -0800 [thread overview]
Message-ID: <1386876830.1002.4.camel@smoke> (raw)
In-Reply-To: <52A912E3.1060802@cn.fujitsu.com>
Hi Zhang,
On Thu, 2013-12-12 at 09:35 +0800, Zhang Yanfei wrote:
> On 12/12/2013 08:18 AM, Geoff Levand wrote:
> > Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
> > all the possible kexec IND_ kimage_entry indirection flags.
> >
> > Having this macro allows for simplified code in the prosessing of the
> > kexec kimage_entry items.
>
> Where? I didn't see any place you use this macro to help simplification.
As in powerpc, it allows constructions like this:
switch (entry & IND_FLAGS) {
case IND_DESTINATION:
...
case IND_INDIRECTION:
...
}
-Geoff
next prev parent reply other threads:[~2013-12-12 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 0:18 [PATCH 0/4] Minor fixes and improvements for kexec Geoff Levand
2013-12-12 0:18 ` [PATCH 3/4] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2013-12-12 0:18 ` [PATCH 2/4] kexec: Add " Geoff Levand
2013-12-12 1:35 ` Zhang Yanfei
2013-12-12 19:33 ` Geoff Levand [this message]
2013-12-12 5:11 ` [PATCH 0/4] Minor fixes and improvements for kexec Simon Horman
2013-12-17 5:37 ` WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386876830.1002.4.camel@smoke \
--to=geoff@infradead.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).