From: Michael Ellerman <mpe@ellerman.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: mikey@neuling.org, ak@linux.intel.com,
linux-kernel@vger.kernel.org, eranian@google.com,
linuxppc-dev@ozlabs.org, acme@ghostprotocols.net,
sukadev@linux.vnet.ibm.com, mingo@kernel.org
Subject: Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework
Date: Fri, 13 Dec 2013 13:47:42 +1100 [thread overview]
Message-ID: <1386902862.3853.0.camel@concordia> (raw)
In-Reply-To: <52A9779B.1030003@linux.vnet.ibm.com>
On Thu, 2013-12-12 at 14:15 +0530, Anshuman Khandual wrote:
> On 12/10/2013 11:27 AM, Anshuman Khandual wrote:
> > On 12/09/2013 11:51 AM, Michael Ellerman wrote:
> >> This code was already in need of some unindentation, and now it's just
> >> ridiculous.
> >>
> >> To start with at the beginning of this routine we have:
> >>
> >> while (..) {
> >> if (!val)
> >> break;
> >> else {
> >> // Bulk of the logic
> >> ...
> >> }
> >> }
> >>
> >> That should almost always become:
> >>
> >> while (..) {
> >> if (!val)
> >> break;
> >>
> >> // Bulk of the logic
> >> ...
> >> }
> >>
> >>
> >> But in this case that's not enough. Please send a precursor patch which moves
> >> this logic out into a helper function.
> >
> > Hey Michael,
> >
> > I believe this patch should be able to take care of this.
...
> Does the patch looks okay ? In which case will send it out separately. Do let
> me know. Thank you.
It's OK.
Don't send it out separately, make it the first patch in your series.
cheers
next prev parent reply other threads:[~2013-12-13 2:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 10:32 [PATCH V4 00/10] perf: New conditional branch filter Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 01/10] perf: Add PERF_SAMPLE_BRANCH_COND Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 02/10] powerpc, perf: Enable conditional branch filter for POWER8 Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 03/10] perf, tool: Conditional branch filter 'cond' added to perf record Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 04/10] x86, perf: Add conditional branch filtering support Anshuman Khandual
2013-12-06 16:46 ` Andi Kleen
2013-12-04 10:32 ` [PATCH V4 05/10] perf, documentation: Description for conditional branch filter Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 06/10] powerpc, perf: Change the name of HW PMU branch filter tracking variable Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 07/10] powerpc, lib: Add new branch instruction analysis support functions Anshuman Khandual
2013-12-09 6:21 ` Michael Ellerman
2013-12-10 6:09 ` Anshuman Khandual
2013-12-20 10:06 ` Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework Anshuman Khandual
2013-12-09 6:21 ` Michael Ellerman
2013-12-10 5:57 ` Anshuman Khandual
2013-12-12 8:45 ` Anshuman Khandual
2013-12-13 2:47 ` Michael Ellerman [this message]
2013-12-20 11:01 ` Anshuman Khandual
2013-12-24 3:29 ` Michael Ellerman
2013-12-24 3:50 ` Anshuman Khandual
2013-12-24 4:35 ` Michael Ellerman
2013-12-04 10:32 ` [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration Anshuman Khandual
2013-12-09 6:21 ` Michael Ellerman
2013-12-13 8:20 ` Anshuman Khandual
2013-12-18 0:08 ` Michael Ellerman
2013-12-18 3:55 ` Anshuman Khandual
2013-12-04 10:32 ` [PATCH V4 10/10] powerpc, perf: Cleanup SW branch filter list look up Anshuman Khandual
2013-12-09 6:21 ` Michael Ellerman
2013-12-20 11:06 ` Anshuman Khandual
2013-12-05 4:47 ` [PATCH V4 00/10] perf: New conditional branch filter Michael Ellerman
2013-12-06 13:18 ` Arnaldo Carvalho de Melo
2013-12-09 0:41 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386902862.3853.0.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).