From: Joe Perches <joe@perches.com>
To: Anton Blanchard <anton@samba.org>
Cc: Dinar Valeev <dvaleev@suse.com>,
linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.de>,
netdev@vger.kernel.org, Santiago Leon <santil@linux.vnet.ibm.com>
Subject: Re: [PATCH] ibmveth: Fix more little endian issues
Date: Mon, 23 Dec 2013 06:52:09 -0800 [thread overview]
Message-ID: <1387810329.22671.66.camel@joe-AO722> (raw)
In-Reply-To: <20131223173833.0a9a6705@kryten>
On Mon, 2013-12-23 at 17:38 +1100, Anton Blanchard wrote:
> The hypervisor expects MAC addresses passed in registers to be big
> endian u64.
So maybe use __be64 declarations?
> +static unsigned long ibmveth_encode_mac_addr(char *mac)
static __be64 ibmveth_encode_mac_addr(const char *mac)
?
etc...
next prev parent reply other threads:[~2013-12-23 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 1:29 [PATCH] ibmveth: Fix more little endian issues Alexander Graf
2013-12-23 6:38 ` Anton Blanchard
2013-12-23 10:17 ` Alexander Graf
2013-12-23 14:52 ` Joe Perches [this message]
2013-12-24 1:55 ` Anton Blanchard
2013-12-25 10:38 ` Ben Hutchings
2014-03-05 3:51 ` ibmveth: Fix endian issues with MAC addresses Anton Blanchard
2014-03-06 21:27 ` David Miller
2013-12-24 4:37 ` [PATCH] ibmveth: Fix more little endian issues Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387810329.22671.66.camel@joe-AO722 \
--to=joe@perches.com \
--cc=agraf@suse.de \
--cc=anton@samba.org \
--cc=dvaleev@suse.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).